From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Yann Sionneau <ysionneau@kalrayinc.com>,
Michael Olbrich <mol@pengutronix.de>
Subject: Re: [PATCH] kbuild: treat char as always unsigned
Date: Fri, 25 Apr 2025 07:37:12 +0200 [thread overview]
Message-ID: <174555943224.526916.17595769821668765033.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20250422063910.126829-1-a.fatoum@pengutronix.de>
On Tue, 22 Apr 2025 08:39:10 +0200, Ahmad Fatoum wrote:
> The C standard makes it implementation defined whether a plain char is
> unsigned or signed and the architectures where barebox is compiled for
> differ in that, e.g. chars are traditionally unsigned on ARM, but on x86
> for example they tend to be signed.
>
> This caused different bugs[1][2][3] in the past, especially around
> behavior when casted to int. Let's instruct the compiler to treat char
> as always unsigned. This may fix some issues that flew under the radar
> so far, but also break drivers that were compiled and used only for
> specific architectures, which implicitly assumed char is signed, which
> we'll have to fix.
>
> [...]
Applied, thanks!
[1/1] kbuild: treat char as always unsigned
https://git.pengutronix.de/cgit/barebox/commit/?id=b2ea1b4511b9 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2025-04-25 5:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 6:39 Ahmad Fatoum
2025-04-22 7:42 ` Sascha Hauer
2025-04-22 7:52 ` Ahmad Fatoum
2025-04-22 8:14 ` Sascha Hauer
2025-04-25 5:37 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174555943224.526916.17595769821668765033.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=mol@pengutronix.de \
--cc=ysionneau@kalrayinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox