From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 25 Apr 2025 07:38:04 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u8BlD-0058FC-37 for lore@lore.pengutronix.de; Fri, 25 Apr 2025 07:38:03 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1u8BlC-0004Pr-0f for lore@pengutronix.de; Fri, 25 Apr 2025 07:38:03 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Date:Message-Id:Subject:References:In-Reply-To:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BfXA8u9WjHUk+kP1r2/+cRw3fNVeD+bO/jliz107Joc=; b=vqAu6R5hbVUigP0pTqbWAVbhgA ZzONRrqFbxAafsMRv+0o3OSpa31EtZ0xdgeSL76Q+RSM0vTSB98+i5jU5bXssr3nl+Z4dFgCuFQ7F XzFeq1nFL2xak5LX0+E923DuaA7SqLQB0poRCIxOhxOoAYGs8EXh0szy+LDRX0wyp1kgejIlf/Ki6 S2QTJh5yq7UhqCQ1nPqbJ94j8ke6QTv65OVqYQ+tv3K5RpQaLM58gPmIRJ3jRD+oPWon67s74sLUE 22o2qlANAfEsM6PopJ1VzeL+zENLF6FMJE+svLhA5t5aWguj7xEISRiBvbGe4M97cw8mPIvASN1Z0 N4BOwLpg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u8BkV-0000000FzXl-0D2u; Fri, 25 Apr 2025 05:37:19 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u8BkS-0000000FzXO-28V0 for barebox@lists.infradead.org; Fri, 25 Apr 2025 05:37:18 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1u8BkO-0004Hm-ML; Fri, 25 Apr 2025 07:37:12 +0200 Received: from dude02.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::28]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u8BkO-001zmK-15; Fri, 25 Apr 2025 07:37:12 +0200 Received: from localhost ([::1] helo=dude02.red.stw.pengutronix.de) by dude02.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1u8BkO-002D7S-0o; Fri, 25 Apr 2025 07:37:12 +0200 From: Sascha Hauer To: barebox@lists.infradead.org, Ahmad Fatoum Cc: Yann Sionneau , Michael Olbrich In-Reply-To: <20250422063910.126829-1-a.fatoum@pengutronix.de> References: <20250422063910.126829-1-a.fatoum@pengutronix.de> Message-Id: <174555943224.526916.17595769821668765033.b4-ty@pengutronix.de> Date: Fri, 25 Apr 2025 07:37:12 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250424_223716_553366_FE3ABF32 X-CRM114-Status: UNSURE ( 9.73 ) X-CRM114-Notice: Please train this message. X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.6 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH] kbuild: treat char as always unsigned X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On Tue, 22 Apr 2025 08:39:10 +0200, Ahmad Fatoum wrote: > The C standard makes it implementation defined whether a plain char is > unsigned or signed and the architectures where barebox is compiled for > differ in that, e.g. chars are traditionally unsigned on ARM, but on x86 > for example they tend to be signed. > > This caused different bugs[1][2][3] in the past, especially around > behavior when casted to int. Let's instruct the compiler to treat char > as always unsigned. This may fix some issues that flew under the radar > so far, but also break drivers that were compiled and used only for > specific architectures, which implicitly assumed char is signed, which > we'll have to fix. > > [...] Applied, thanks! [1/1] kbuild: treat char as always unsigned https://git.pengutronix.de/cgit/barebox/commit/?id=b2ea1b4511b9 (link may not be stable) Best regards, -- Sascha Hauer