[PATCH] fixup! commands: devlookup: add support for cdev aliases

[PATCH] fixup! commands: devlookup: add support for cdev aliases

[Ahmad Fatoum]

commands: devlookup: fix memory leak in error case

There's a string_list_free after out:, which we are skipping when we
directly return.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 commands/devlookup.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/commands/devlookup.c b/commands/devlookup.c
index 5877d5f1b82c..b7fd7be3b624 100644
--- a/commands/devlookup.c
+++ b/commands/devlookup.c
@@ -59,7 +59,8 @@ static int do_devlookup(int argc, char *argv[])
 		aliasbuf = string_list_join(&sl, " ");
 		if (string_list_count(&sl) > 1 && (kernelopt || paramname)) {
 			printf("Option not supported for multi cdev alias\n");
-			return COMMAND_ERROR;
+			ret = COMMAND_ERROR;
+			goto out;
 		}
 
 		if (alias) {
-- 
2.39.5

Re: [PATCH] fixup! commands: devlookup: add support for cdev aliases

[Sascha Hauer]

On Fri, 25 Apr 2025 07:48:39 +0200, Ahmad Fatoum wrote:
> commands: devlookup: fix memory leak in error case
> 
> There's a string_list_free after out:, which we are skipping when we
> directly return.
> 
> 

Applied, thanks!

[1/1] fixup! commands: devlookup: add support for cdev aliases
      https://git.pengutronix.de/cgit/barebox/commit/?id=d6e0dfb84eaf (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>