mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH master] commands: bthread: fix format specifier for ulong
@ 2025-05-28  5:57 Ahmad Fatoum
  2025-06-02 11:45 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2025-05-28  5:57 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

Adding __printf to the bthread_run definition in the follow up commit
will make it evident that we are using a wrong type for a %u format
specifier.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
To avoid intermittent breakage, please apply before:
https://lore.barebox.org/barebox/20250527201359.889550-1-a.fatoum@pengutronix.de/T/#t
---
 commands/bthread.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/commands/bthread.c b/commands/bthread.c
index 7a16c6713da5..f3b3e517ebf2 100644
--- a/commands/bthread.c
+++ b/commands/bthread.c
@@ -106,7 +106,7 @@ static void bthread_spawner(void *_spawner_arg)
 		arg = malloc(sizeof(*arg));
 		arg->in = i;
 		bthread[i] = bthread_run(bthread_printer, arg,
-					 "%s-bthread%u", bthread_name(current), i+1);
+					 "%s-bthread%lu", bthread_name(current), i+1);
 		if (!bthread[i]) {
 			ret = -ENOMEM;
 			goto cleanup;
-- 
2.39.5




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH master] commands: bthread: fix format specifier for ulong
  2025-05-28  5:57 [PATCH master] commands: bthread: fix format specifier for ulong Ahmad Fatoum
@ 2025-06-02 11:45 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2025-06-02 11:45 UTC (permalink / raw)
  To: barebox, Ahmad Fatoum


On Wed, 28 May 2025 07:57:51 +0200, Ahmad Fatoum wrote:
> Adding __printf to the bthread_run definition in the follow up commit
> will make it evident that we are using a wrong type for a %u format
> specifier.
> 
> 

Applied, thanks!

[1/1] commands: bthread: fix format specifier for ulong
      https://git.pengutronix.de/cgit/barebox/commit/?id=54b15cf42fa0 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-06-02 11:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-28  5:57 [PATCH master] commands: bthread: fix format specifier for ulong Ahmad Fatoum
2025-06-02 11:45 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox