From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH 1/2] string: add delimiter output parameter to strsep_unescaped
Date: Mon, 02 Jun 2025 13:47:18 +0200 [thread overview]
Message-ID: <174886483824.917513.8183669695291275158.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20250528055814.1368888-1-a.fatoum@pengutronix.de>
On Wed, 28 May 2025 07:58:13 +0200, Ahmad Fatoum wrote:
> strsep overwrites the found delimiter with '\0' making it cumbersome for
> callers that match on multiple delimiters to find out, which delimiter
> actually matched.
>
> Parsers that split on multiple delimiters are likely to want support
> escaping them too, so let's add an extra output parameter to
> strsep_unescaped to make it possible to retrieve the delimiter that was
> ultimately overwritten.
>
> [...]
Applied, thanks!
[1/2] string: add delimiter output parameter to strsep_unescaped
https://git.pengutronix.de/cgit/barebox/commit/?id=b6f86a80f0b5 (link may not be stable)
[2/2] test: self: string: add test cases for strsep_unescaped
https://git.pengutronix.de/cgit/barebox/commit/?id=7c75114a99f2 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2025-06-02 11:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-28 5:58 Ahmad Fatoum
2025-05-28 5:58 ` [PATCH 2/2] test: self: string: add test cases for strsep_unescaped Ahmad Fatoum
2025-06-02 11:47 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174886483824.917513.8183669695291275158.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox