From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH master] of: fdt: fix overflowing in dt_struct_advance arguments
Date: Thu, 12 Jun 2025 09:44:06 +0200 [thread overview]
Message-ID: <174971424616.148381.10729712484564046239.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20250611063910.754462-1-a.fatoum@pengutronix.de>
On Wed, 11 Jun 2025 08:39:10 +0200, Ahmad Fatoum wrote:
> While dt_struct_advance was taking care to check its arguments don't
> overflow their type, the addition of len (that is read from the FDT)
> to a constant was already overflowing before the function was called.
>
> Move all additions with untrusted input into the function to fix this.
>
> This resolves crashes detected by libfuzzer when the digest functions
> were ultimately called with a length of -1 == 0xffffffff.
>
> [...]
Applied, thanks!
[1/1] of: fdt: fix overflowing in dt_struct_advance arguments
https://git.pengutronix.de/cgit/barebox/commit/?id=26136fd068d7 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2025-06-12 8:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 6:39 Ahmad Fatoum
2025-06-11 7:01 ` Sascha Hauer
2025-06-11 7:51 ` Ahmad Fatoum
2025-06-12 7:44 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174971424616.148381.10729712484564046239.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox