[PATCH] console: handle input consoles in of_console_by_stdout_path() gracefully

[PATCH] console: handle input consoles in of_console_by_stdout_path() gracefully

[Bastian Krause]

With CONFIG_INPUT=y, inputs are registered as consoles without setting
the dev member. This leads to a NULL pointer dereference when passed to
dev_of_node().

So add a check prior to calling dev_of_node() with a NULL pointer to
prevent this.

Signed-off-by: Bastian Krause <bst@pengutronix.de>
---
 common/console.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/console.c b/common/console.c
index f94dbe3243c..424290b6cd1 100644
--- a/common/console.c
+++ b/common/console.c
@@ -264,7 +264,7 @@ struct console_device *of_console_by_stdout_path(void)
 		return NULL;
 
 	for_each_console(console) {
-		if (dev_of_node(console->dev) == stdout_np)
+		if (console->dev && dev_of_node(console->dev) == stdout_np)
 			return console;
 	}
 
-- 
2.39.5

Re: [PATCH] console: handle input consoles in of_console_by_stdout_path() gracefully

[Sascha Hauer]

On Tue, 17 Jun 2025 14:42:38 +0200, Bastian Krause wrote:
> With CONFIG_INPUT=y, inputs are registered as consoles without setting
> the dev member. This leads to a NULL pointer dereference when passed to
> dev_of_node().
> 
> So add a check prior to calling dev_of_node() with a NULL pointer to
> prevent this.
> 
> [...]

Applied, thanks!

[1/1] console: handle input consoles in of_console_by_stdout_path() gracefully
      https://git.pengutronix.de/cgit/barebox/commit/?id=7657eaf3ed3b (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>