* [PATCH] ARM: at91: sam9_smc: remove redundant SAMA5D2 check
@ 2025-06-20 8:07 Alexander Shiyan
2025-06-20 11:46 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Shiyan @ 2025-06-20 8:07 UTC (permalink / raw)
To: barebox; +Cc: Alexander Shiyan
The SAMA5D2 SoC uses a different SMC driver implementation (located in
drivers/mfd/atmel-smc.c) and doesn't utilize this low-level sam9_smc
driver. The check for AT91_SOC_SAMA5D2 in the read mode function is
therefore redundant and can be safely removed.
This cleanup eliminates dead code and improves maintainability by
removing an unused codepath. No functional changes are introduced.
Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
---
arch/arm/mach-at91/sam9_smc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mach-at91/sam9_smc.c b/arch/arm/mach-at91/sam9_smc.c
index 257d7a07c3..6c9e169a8e 100644
--- a/arch/arm/mach-at91/sam9_smc.c
+++ b/arch/arm/mach-at91/sam9_smc.c
@@ -101,7 +101,6 @@ static void sam9_smc_cs_read_mode(void __iomem *base,
void __iomem *mode_reg;
switch (at91_soc_initdata.type) {
- case AT91_SOC_SAMA5D2:
case AT91_SOC_SAMA5D3:
case AT91_SOC_SAMA5D4:
mode_reg = base + AT91_SAMA5_SMC_MODE;
--
2.39.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: at91: sam9_smc: remove redundant SAMA5D2 check
2025-06-20 8:07 [PATCH] ARM: at91: sam9_smc: remove redundant SAMA5D2 check Alexander Shiyan
@ 2025-06-20 11:46 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2025-06-20 11:46 UTC (permalink / raw)
To: barebox, Alexander Shiyan
On Fri, 20 Jun 2025 11:07:15 +0300, Alexander Shiyan wrote:
> The SAMA5D2 SoC uses a different SMC driver implementation (located in
> drivers/mfd/atmel-smc.c) and doesn't utilize this low-level sam9_smc
> driver. The check for AT91_SOC_SAMA5D2 in the read mode function is
> therefore redundant and can be safely removed.
>
> This cleanup eliminates dead code and improves maintainability by
> removing an unused codepath. No functional changes are introduced.
>
> [...]
Applied, thanks!
[1/1] ARM: at91: sam9_smc: remove redundant SAMA5D2 check
https://git.pengutronix.de/cgit/barebox/commit/?id=cdde08be1a5a (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-20 12:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-20 8:07 [PATCH] ARM: at91: sam9_smc: remove redundant SAMA5D2 check Alexander Shiyan
2025-06-20 11:46 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox