From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Lars Schmidt <l.schmidt@pengutronix.de>
Subject: Re: [PATCH] fixup! bootchooser: implement locking of attempts counter
Date: Tue, 24 Jun 2025 09:19:21 +0200 [thread overview]
Message-ID: <175074956104.505107.1660435797846919378.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20250623131306.2179862-1-a.fatoum@pengutronix.de>
On Mon, 23 Jun 2025 15:13:06 +0200, Ahmad Fatoum wrote:
> We have two code paths with goto err that don't set ret beforehand with
> the expectation that the default -EINVAL will be used.
>
> ret is now being reused though and thus the -EINVAL is clobbered. In the
> worst case, an error ends up with ERR_PTR(ret) == NULL crashing
> bootchooser -i when a state prefix is set, but no targets are defined.
>
> [...]
Applied, thanks!
[1/1] fixup! bootchooser: implement locking of attempts counter
https://git.pengutronix.de/cgit/barebox/commit/?id=77bd8dac6962 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2025-06-24 7:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 13:13 Ahmad Fatoum
2025-06-24 7:19 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175074956104.505107.1660435797846919378.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=l.schmidt@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox