From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@barebox.org>
Cc: Renaud Barbier <Renaud.Barbier@ametek.com>
Subject: Re: [PATCH master] drivers: fix buggy comparisons of casted device_get_match_data to zero
Date: Tue, 05 Aug 2025 10:19:19 +0200 [thread overview]
Message-ID: <175438195946.3493396.9444062364812354742.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20250715201908.2515578-1-a.fatoum@barebox.org>
On Tue, 15 Jul 2025 22:19:08 +0200, Ahmad Fatoum wrote:
> device_get_match_data returns NULL when no match data is available,
> which a cast to uintptr_t turns into a zero.
>
> Most drivers either put valid pointers into the match data or they
> reserve a literal value of zero to be "unknown".
>
> Three drivers don't do that though and use 0 as valid value for the
> match data and thus the check against zero breaks probing drivers with
> the corresponding match data.
>
> [...]
Applied, thanks!
[1/1] drivers: fix buggy comparisons of casted device_get_match_data to zero
https://git.pengutronix.de/cgit/barebox/commit/?id=964a91e4427f (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2025-08-05 9:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 20:19 Ahmad Fatoum
2025-08-05 8:19 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175438195946.3493396.9444062364812354742.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=Renaud.Barbier@ametek.com \
--cc=a.fatoum@barebox.org \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox