From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@barebox.org>
Subject: Re: [PATCH master 1/2] kbuild: images/Makefile: fix broken if_changed usage
Date: Tue, 19 Aug 2025 08:02:08 +0200 [thread overview]
Message-ID: <175558332882.3090489.6361151976873545910.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20250814202254.344010-1-a.fatoum@barebox.org>
On Thu, 14 Aug 2025 22:22:53 +0200, Ahmad Fatoum wrote:
> if_changed also triggers when the command line changes by comparing the
> command executed against what was written last time.
>
> This necessarily means that there may only be a single if_changed called
> per target, a rule which we violated.
>
> This led to breakage on RISC-V, because every build triggered a relink
> of the PBLs, but only every second build executed cmd_prelink__.
>
> [...]
Applied, thanks!
[1/2] kbuild: images/Makefile: fix broken if_changed usage
https://git.pengutronix.de/cgit/barebox/commit/?id=21613ae35f42 (link may not be stable)
[2/2] RISC-V: stacktrace: add missing header for eprintf
https://git.pengutronix.de/cgit/barebox/commit/?id=c23f4202a0ab (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2025-08-19 6:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 20:22 Ahmad Fatoum
2025-08-14 20:22 ` [PATCH master 2/2] RISC-V: stacktrace: add missing header for eprintf Ahmad Fatoum
2025-08-19 6:02 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175558332882.3090489.6361151976873545910.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@barebox.org \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox