mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH master] fastboot: implement dummy has-slot:partition variables
@ 2025-08-20 10:17 Ahmad Fatoum
  2025-08-20 12:29 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2025-08-20 10:17 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

Now that we enforce variables to be available, flashing can result in
following error message:

  ERROR: fastboot: no such variable: has-slot:rootfs-eMMC

Report the default no value to suppress this.

Fixes: dd377c937f8b ("common: fastboot: send FAIL if variable does not exist")
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 common/fastboot.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/common/fastboot.c b/common/fastboot.c
index 603391de7739..e5c79c22376c 100644
--- a/common/fastboot.c
+++ b/common/fastboot.c
@@ -180,6 +180,8 @@ static int fastboot_add_partition_variables(struct fastboot *fb, struct list_hea
 	fb_setvar(var, "%s", type);
 	var = fb_addvar(fb, list, "is-logical:%s", fentry->name);
 	fb_setvar(var, "%s", "no");
+	var = fb_addvar(fb, list, "has-slot:%s", fentry->name);
+	fb_setvar(var, "%s", "no");
 
 	return ret;
 }
-- 
2.39.5




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH master] fastboot: implement dummy has-slot:partition variables
  2025-08-20 10:17 [PATCH master] fastboot: implement dummy has-slot:partition variables Ahmad Fatoum
@ 2025-08-20 12:29 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2025-08-20 12:29 UTC (permalink / raw)
  To: barebox, Ahmad Fatoum


On Wed, 20 Aug 2025 12:17:02 +0200, Ahmad Fatoum wrote:
> Now that we enforce variables to be available, flashing can result in
> following error message:
> 
>   ERROR: fastboot: no such variable: has-slot:rootfs-eMMC
> 
> Report the default no value to suppress this.
> 
> [...]

Applied, thanks!

[1/1] fastboot: implement dummy has-slot:partition variables
      https://git.pengutronix.de/cgit/barebox/commit/?id=525ccfb5ac38 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-08-20 12:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-20 10:17 [PATCH master] fastboot: implement dummy has-slot:partition variables Ahmad Fatoum
2025-08-20 12:29 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox