[PATCH] clk: clkdev: fix format security.

[PATCH] clk: clkdev: fix format security.

[chalianis1]

From: Chali Anis <chalianis1@gmail.com>

not a string literal and no format
arguments [-Werror=format-security]

Fixes: 61da1fea5d3c ("clk: sifive: Fix missing conversion to struct clk_hw")
Signed-off-by: Chali Anis <chalianis1@gmail.com>
---
 drivers/clk/sifive/sifive-prci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/sifive/sifive-prci.c b/drivers/clk/sifive/sifive-prci.c
index 349629d82aa9..dbbf05655850 100644
--- a/drivers/clk/sifive/sifive-prci.c
+++ b/drivers/clk/sifive/sifive-prci.c
@@ -508,7 +508,7 @@ static int __prci_register_clocks(struct device *dev, struct __prci_data *pd,
 			return PTR_ERR(clk);
 		}
 
-		r = clk_register_clkdev(clk, pic->name, dev_name(dev));
+		r = clk_register_clkdev(clk, pic->name, "%s", dev_name(dev));
 		if (r) {
 			dev_warn(dev, "Failed to register clkdev for %s: %d\n",
 				 clk_hw_get_name(&pic->hw), r);
-- 
2.34.1

Re: [PATCH] clk: clkdev: fix format security.

[Sascha Hauer]

On Sat, 30 Aug 2025 14:29:17 -0400, chalianis1@gmail.com wrote:
> not a string literal and no format
> arguments [-Werror=format-security]
> 
> 

Applied, thanks!

[1/1] clk: clkdev: fix format security.
      https://git.pengutronix.de/cgit/barebox/commit/?id=85e8514df331 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>

[PATCH] clk: clkdev: fix format security.

[chalianis1]

From: Chali Anis <chalianis1@gmail.com>

not a string literal and no format
arguments [-Werror=format-security]

Fixes: dfcdce8eec30 ("arm: add common clkdev")
Signed-off-by: Chali Anis <chalianis1@gmail.com>
---
 drivers/clk/clkdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
index dbe998b6af35..1ce2eb95b8f9 100644
--- a/drivers/clk/clkdev.c
+++ b/drivers/clk/clkdev.c
@@ -273,7 +273,7 @@ int clk_add_alias(const char *alias, const char *alias_dev_name, char *id,
 	if (IS_ERR(r))
 		return PTR_ERR(r);
 
-	l = clkdev_alloc(r, alias, alias_dev_name);
+	l = clkdev_alloc(r, alias, "%s", alias_dev_name);
 	clk_put(r);
 	if (!l)
 		return -ENODEV;
-- 
2.34.1

Re: [PATCH] clk: clkdev: fix format security.

[Ahmad Fatoum]

Hi,

On 7/29/25 06:56, chalianis1@gmail.com wrote:
> From: Chali Anis <chalianis1@gmail.com>
> 
> not a string literal and no format
> arguments [-Werror=format-security]
> 
> Fixes: dfcdce8eec30 ("arm: add common clkdev")
> Signed-off-by: Chali Anis <chalianis1@gmail.com>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Thanks,
Ahmad

> ---
>  drivers/clk/clkdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
> index dbe998b6af35..1ce2eb95b8f9 100644
> --- a/drivers/clk/clkdev.c
> +++ b/drivers/clk/clkdev.c
> @@ -273,7 +273,7 @@ int clk_add_alias(const char *alias, const char *alias_dev_name, char *id,
>  	if (IS_ERR(r))
>  		return PTR_ERR(r);
>  
> -	l = clkdev_alloc(r, alias, alias_dev_name);
> +	l = clkdev_alloc(r, alias, "%s", alias_dev_name);
>  	clk_put(r);
>  	if (!l)
>  		return -ENODEV;

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

Re: [PATCH] clk: clkdev: fix format security.

[Sascha Hauer]

On Tue, 29 Jul 2025 00:56:07 -0400, chalianis1@gmail.com wrote:
> not a string literal and no format
> arguments [-Werror=format-security]
> 
> 

Applied, thanks!

[1/1] clk: clkdev: fix format security.
      https://git.pengutronix.de/cgit/barebox/commit/?id=ffeeae51a5cf (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>