[PATCH] fs: jffs2: silence false positive by always initializing variable

[PATCH] fs: jffs2: silence false positive by always initializing variable

[Ahmad Fatoum]

buffer is not initialized when pointed is true, but that can't
happen, because, unlike Linux, we hardcode the value at 0.

clang warns about that though, so fix the warning by always
initializing buffer.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 fs/jffs2/readinode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/jffs2/readinode.c b/fs/jffs2/readinode.c
index d56001e5cbb8..c205917619cd 100644
--- a/fs/jffs2/readinode.c
+++ b/fs/jffs2/readinode.c
@@ -30,7 +30,7 @@ static int check_node_data(struct jffs2_sb_info *c, struct jffs2_tmp_dnode_info
 	struct jffs2_raw_node_ref *ref = tn->fn->raw;
 	int err = 0, pointed = 0;
 	struct jffs2_eraseblock *jeb;
-	unsigned char *buffer;
+	unsigned char *buffer = NULL;
 	uint32_t crc, ofs, len;
 	size_t retlen;
 
-- 
2.47.2

Re: [PATCH] fs: jffs2: silence false positive by always initializing variable

[Sascha Hauer]

On Mon, 01 Sep 2025 13:38:07 +0200, Ahmad Fatoum wrote:
> buffer is not initialized when pointed is true, but that can't
> happen, because, unlike Linux, we hardcode the value at 0.
> 
> clang warns about that though, so fix the warning by always
> initializing buffer.
> 
> 
> [...]

Applied, thanks!

[1/1] fs: jffs2: silence false positive by always initializing variable
      https://git.pengutronix.de/cgit/barebox/commit/?id=6d778f786e7f (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>