From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@barebox.org>
Cc: Chali Anis <chalianis1@gmail.com>
Subject: Re: [PATCH] ARM64: setupc: drop erroneous cache flush of virt addr 0
Date: Fri, 12 Sep 2025 09:51:27 +0200 [thread overview]
Message-ID: <175766348749.1759635.5276624269090803798.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20250912065105.2443411-1-a.fatoum@barebox.org>
On Fri, 12 Sep 2025 08:51:04 +0200, Ahmad Fatoum wrote:
> relocate_to_adr copies around executable code and thus needs to
> ensure coherence between I$ and D$. When the function was first added,
> it didn't maintain cache correctly, because while it did call
> arm_early_mmu_cache_flush(), back then that function did not invalidate
> I$ after the D$ clean.
>
> This likely went unnoticed, because a comment in relocate_to_adr
> suggested that ic ivau is invalidating the I$, but in reality that
> instruction did an unconditional invalidation of the single
> cache line corresponding to virtual address 0 if it exists.
>
> [...]
Applied, thanks!
[1/1] ARM64: setupc: drop erroneous cache flush of virt addr 0
https://git.pengutronix.de/cgit/barebox/commit/?id=cca8ff2e8810 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2025-09-12 7:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 6:51 Ahmad Fatoum
2025-09-12 7:51 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175766348749.1759635.5276624269090803798.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@barebox.org \
--cc=barebox@lists.infradead.org \
--cc=chalianis1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox