[PATCH] dm: fix memory leak

[PATCH] dm: fix memory leak

[Sascha Hauer]

a dm_target is allocated in dm_parse_table(), thus must be freed in
dm_destroy(). The destroy op only frees everything related to the
dm_target, but not the dm_target itself.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/block/dm/dm-core.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/block/dm/dm-core.c b/drivers/block/dm/dm-core.c
index 1bc3446cb0..fd7ed0d84e 100644
--- a/drivers/block/dm/dm-core.c
+++ b/drivers/block/dm/dm-core.c
@@ -428,6 +428,7 @@ static int dm_parse_table(struct dm_device *dm, const char *ctable)
 	list_for_each_entry_safe_reverse(ti, tmp, &dm->targets, list) {
 		ti->ops->destroy(ti);
 		list_del(&ti->list);
+		free(ti);
 	}
 
 	free(rowv);
@@ -439,12 +440,13 @@ static int dm_parse_table(struct dm_device *dm, const char *ctable)
 
 void dm_destroy(struct dm_device *dm)
 {
-	struct dm_target *ti;
+	struct dm_target *ti, *tmp;
 
 	blockdevice_unregister(&dm->blk);
 
-	list_for_each_entry_reverse(ti, &dm->targets, list) {
+	list_for_each_entry_safe_reverse(ti, tmp, &dm->targets, list) {
 		ti->ops->destroy(ti);
+		free(ti);
 	}
 
 	unregister_device(&dm->dev);
-- 
2.47.3

Re: [PATCH] dm: fix memory leak

[Sascha Hauer]

On Mon, 10 Nov 2025 09:17:49 +0100, Sascha Hauer wrote:
> a dm_target is allocated in dm_parse_table(), thus must be freed in
> dm_destroy(). The destroy op only frees everything related to the
> dm_target, but not the dm_target itself.
> 
> 

Applied, thanks!

[1/1] dm: fix memory leak
      https://git.pengutronix.de/cgit/barebox/commit/?id=38010b583b28 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>