* [PATCH] fixup! video: fsl-ldb: add ported driver from linux kernel
@ 2025-11-28 20:09 Ahmad Fatoum
2025-12-01 8:54 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2025-11-28 20:09 UTC (permalink / raw)
To: barebox; +Cc: Ahmad Fatoum
video: fsl-ldb: fix unintended implicit fallthroughs
Coverity flagged this fallthroughs and they indeed look unintended.
Cc: Michael Grzeschik <m.grzeschik@pengutronix.de>
Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
---
drivers/video/fsl-ldb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/fsl-ldb.c b/drivers/video/fsl-ldb.c
index 3fca7867a2a3..0ab720032ccb 100644
--- a/drivers/video/fsl-ldb.c
+++ b/drivers/video/fsl-ldb.c
@@ -220,8 +220,10 @@ static int fsl_ldb_ioctl(struct vpl *vpl, unsigned int port,
break;
case VPL_UNPREPARE:
fsl_ldb_atomic_disable(fsl_ldb);
+ break;
case VPL_PREPARE:
fsl_ldb_atomic_enable(fsl_ldb, data);
+ break;
case VPL_GET_VIDEOMODES:
if (fsl_ldb->modes) {
struct display_timings *timings = data;
--
2.47.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fixup! video: fsl-ldb: add ported driver from linux kernel
2025-11-28 20:09 [PATCH] fixup! video: fsl-ldb: add ported driver from linux kernel Ahmad Fatoum
@ 2025-12-01 8:54 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2025-12-01 8:54 UTC (permalink / raw)
To: barebox, Ahmad Fatoum
On Fri, 28 Nov 2025 21:09:56 +0100, Ahmad Fatoum wrote:
> video: fsl-ldb: fix unintended implicit fallthroughs
>
> Coverity flagged this fallthroughs and they indeed look unintended.
>
>
Applied, thanks!
[1/1] fixup! video: fsl-ldb: add ported driver from linux kernel
https://git.pengutronix.de/cgit/barebox/commit/?id=ea57ae858deb (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-01 8:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-28 20:09 [PATCH] fixup! video: fsl-ldb: add ported driver from linux kernel Ahmad Fatoum
2025-12-01 8:54 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox