From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, "Enrico Jörns" <ejo@pengutronix.de>
Subject: Re: [PATCH] block: don't error while flushing when write support is disabled
Date: Fri, 16 Jan 2026 08:12:08 +0100 [thread overview]
Message-ID: <176854752829.1285388.16282232398181542926.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20260115142410.3422704-1-ejo@pengutronix.de>
On Thu, 15 Jan 2026 15:24:01 +0100, Enrico Jörns wrote:
> If write support for the underlying device is disabled (e.g. by
> disabling CONFIG_MCI_WRITE), blk->ops->write will be NULL.
> Unconditionally dereferencing/calling blk->ops->write() results in a
> NULL pointer dereference.
>
> Fix this by making chunk_flush() a noop for missing write support.
> Don't return an error since there should be nothing to flush if write
> support is disabled, anyway.
>
> [...]
Applied, thanks!
[1/1] block: don't error while flushing when write support is disabled
https://git.pengutronix.de/cgit/barebox/commit/?id=ddeff3d01e3d (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2026-01-16 7:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 14:24 Enrico Jörns
2026-01-15 14:52 ` Ahmad Fatoum
2026-01-16 7:12 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176854752829.1285388.16282232398181542926.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=ejo@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox