mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH master] pmdomain: rockchip: enable driver by default
@ 2026-01-20 15:58 Ahmad Fatoum
  2026-01-23  7:11 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2026-01-20 15:58 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

Failure to enable the driver leads to annoying warnings in the best
case:

  WARNING: rockchip-dw-pcie 3c0000000.pcie@fe260000.of: power domain not found (ignoring)

and to hangs in the worst case. The defconfigs already enable the
device, but it should really be default y whenever CONFIG_ARCH_ROCKCHIP=y.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/pmdomain/rockchip/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pmdomain/rockchip/Kconfig b/drivers/pmdomain/rockchip/Kconfig
index 0ee292b45b31..05c6c73bbcc5 100644
--- a/drivers/pmdomain/rockchip/Kconfig
+++ b/drivers/pmdomain/rockchip/Kconfig
@@ -5,6 +5,7 @@ config ROCKCHIP_PM_DOMAINS
 	bool "Rockchip generic power domain"
 	depends on REGULATOR
 	select PM_GENERIC_DOMAINS
+	default ARCH_ROCKCHIP
 	help
 	  Say y here to enable power domain support.
 	  The PMU is dedicated for managing the power of the whole chip and may
-- 
2.47.3




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH master] pmdomain: rockchip: enable driver by default
  2026-01-20 15:58 [PATCH master] pmdomain: rockchip: enable driver by default Ahmad Fatoum
@ 2026-01-23  7:11 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2026-01-23  7:11 UTC (permalink / raw)
  To: barebox, Ahmad Fatoum


On Tue, 20 Jan 2026 16:58:59 +0100, Ahmad Fatoum wrote:
> Failure to enable the driver leads to annoying warnings in the best
> case:
> 
>   WARNING: rockchip-dw-pcie 3c0000000.pcie@fe260000.of: power domain not found (ignoring)
> 
> and to hangs in the worst case. The defconfigs already enable the
> device, but it should really be default y whenever CONFIG_ARCH_ROCKCHIP=y.
> 
> [...]

Applied, thanks!

[1/1] pmdomain: rockchip: enable driver by default
      https://git.pengutronix.de/cgit/barebox/commit/?id=15df91cf2dee (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-01-23  7:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-20 15:58 [PATCH master] pmdomain: rockchip: enable driver by default Ahmad Fatoum
2026-01-23  7:11 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox