From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH master] bootm: fix bootm override saving/restoring
Date: Tue, 27 Jan 2026 08:58:58 +0100 [thread overview]
Message-ID: <176950073831.2115366.11360524241031886088.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20260126104656.832582-1-a.fatoum@pengutronix.de>
On Mon, 26 Jan 2026 11:46:44 +0100, Ahmad Fatoum wrote:
> As bootm_set_overrides() only sets non-NULL members, it's not suitable
> to restore old settings as once a member is non-NULL, it can't change
> it.
>
> This may lead to use-after-frees, as the original strings are free'd,
> but the override keeps pointing at it.
> Fix this by merging overrides only before the boot and resetting all
> members after.
>
> [...]
Applied, thanks!
[1/1] bootm: fix bootm override saving/restoring
https://git.pengutronix.de/cgit/barebox/commit/?id=e0b19f3ac155 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2026-01-27 7:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 10:46 Ahmad Fatoum
2026-01-27 7:58 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176950073831.2115366.11360524241031886088.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox