mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH master 00/39] efi: fix bugs
Date: Mon, 23 Feb 2026 10:47:15 +0100	[thread overview]
Message-ID: <177184003551.196034.5369311725997865056.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20260216084758.3548990-1-a.fatoum@pengutronix.de>


On Mon, 16 Feb 2026 09:44:00 +0100, Ahmad Fatoum wrote:
> While adding new tests for the barebox EFI support, a number of issues
> were unearthed. Additionally, I ran Claude Code to determine suspicious
> looking patterns and it found a number of extra issues, mostly in error
> paths.
> 
> Except for patches 36, 37 and 38, all other patches affect only efi/,
> so I hope it's ok to merge into master after review.
> 
> [...]

Applied, thanks!

[01/39] efi: fix potential NULL dereference
        https://git.pengutronix.de/cgit/barebox/commit/?id=c54a80c2e557 (link may not be stable)
[02/39] efi: trace: fix EFI_EXIT2 to not evaluate output value on error
        https://git.pengutronix.de/cgit/barebox/commit/?id=dac494e8d3b9 (link may not be stable)
[03/39] efi: loader: fix CRC32 computation in table header update
        https://git.pengutronix.de/cgit/barebox/commit/?id=f34f05ff87cf (link may not be stable)
[04/39] efi: loader: fix pointer vs value comparison in free_efi_only
        https://git.pengutronix.de/cgit/barebox/commit/?id=ec70e6c48318 (link may not be stable)
[05/39] efi: loader: fix disk write return value check
        https://git.pengutronix.de/cgit/barebox/commit/?id=e3171f94eebd (link may not be stable)
[06/39] efi: loader: fix EFI_ENTRY/EFI_EXIT ordering in efi_set_time
        https://git.pengutronix.de/cgit/barebox/commit/?id=4103d794756a (link may not be stable)
[07/39] efi: runtime: fix missing EFI_EXIT in efirt_query_variable_info
        https://git.pengutronix.de/cgit/barebox/commit/?id=08e2480340d1 (link may not be stable)
[08/39] efi: loader: fix file handle leak in efi_file_from_path
        https://git.pengutronix.de/cgit/barebox/commit/?id=33fee4de545c (link may not be stable)
[09/39] efi: loader: fix missing field init in deferred protocol add
        https://git.pengutronix.de/cgit/barebox/commit/?id=14dbf7ec2382 (link may not be stable)
[10/39] efi: loader: fix memory leak in efi_var_to_file
        https://git.pengutronix.de/cgit/barebox/commit/?id=d47891ef7964 (link may not be stable)
[11/39] efi: loader: fix multiple bugs in efi_loader_bootm
        https://git.pengutronix.de/cgit/barebox/commit/?id=8cd0c65b4438 (link may not be stable)
[12/39] efi: loader: fix return type and memory leak in efi_smbios_register
        https://git.pengutronix.de/cgit/barebox/commit/?id=3837daaf8632 (link may not be stable)
[13/39] efi: loader: fix memory leak in efi_dp_split_file_path
        https://git.pengutronix.de/cgit/barebox/commit/?id=a829aa1632f4 (link may not be stable)
[14/39] efi: loader: fix HII string table realloc and memset bugs
        https://git.pengutronix.de/cgit/barebox/commit/?id=6e5ed7905aaa (link may not be stable)
[15/39] efi: loader: fix format specifier and missing EFI_EXIT in boot services
        https://git.pengutronix.de/cgit/barebox/commit/?id=080db65e39a8 (link may not be stable)
[16/39] efi: fix unreachable free in efi_set_variable_printf
        https://git.pengutronix.de/cgit/barebox/commit/?id=d948429c5194 (link may not be stable)
[17/39] efi: payload: fix missing NULL check after read_file in handover
        https://git.pengutronix.de/cgit/barebox/commit/?id=444cf98b04f3 (link may not be stable)
[18/39] efi: payload: fix EFI page leak in efi_read_file
        https://git.pengutronix.de/cgit/barebox/commit/?id=57a8797d60ad (link may not be stable)
[19/39] efi: payload: fix inverted error check after state_load
        https://git.pengutronix.de/cgit/barebox/commit/?id=91d905b8a0c2 (link may not be stable)
[20/39] efi: fix out-of-bounds read in device path unknown node printing
        https://git.pengutronix.de/cgit/barebox/commit/?id=2a6a61f1838d (link may not be stable)
[21/39] efi: payload: fix wrong page count in efi_unload_fdt
        https://git.pengutronix.de/cgit/barebox/commit/?id=52b9834dd54c (link may not be stable)
[22/39] efi: fix out-of-bounds read in 1394 device path printing
        https://git.pengutronix.de/cgit/barebox/commit/?id=4c1fb0236fa8 (link may not be stable)
[23/39] efi: loader: initialize block IO ops before installing protocol
        https://git.pengutronix.de/cgit/barebox/commit/?id=1a91f3188d1d (link may not be stable)
[24/39] efi: runtime: fix variable store bounds check to account for alignment
        https://git.pengutronix.de/cgit/barebox/commit/?id=a64506f315a8 (link may not be stable)
[25/39] efi: fix Fibre Channel device path type vs sub_type comparison
        https://git.pengutronix.de/cgit/barebox/commit/?id=6fde1114a7d5 (link may not be stable)
[26/39] efi: loader: fix file open mode always setting O_RDWR
        https://git.pengutronix.de/cgit/barebox/commit/?id=5c9e4b749566 (link may not be stable)
[27/39] efi: loader: fix NULL pointer dereference when deleting root volume handle
        https://git.pengutronix.de/cgit/barebox/commit/?id=f1162a2d7c55 (link may not be stable)
[28/39] efi: loader: fix memory leak of variable file buffer on success
        https://git.pengutronix.de/cgit/barebox/commit/?id=38694e38af0c (link may not be stable)
[29/39] efi: loader: fix memory leak in efi_var_collect on buffer overflow
        https://git.pengutronix.de/cgit/barebox/commit/?id=b90ee82d1009 (link may not be stable)
[30/39] efi: fix signed format specifier for uint64_t timestamp
        https://git.pengutronix.de/cgit/barebox/commit/?id=1a3a5454b04e (link may not be stable)
[31/39] efi: payload: fix possible memory leaks during init
        https://git.pengutronix.de/cgit/barebox/commit/?id=337142fb8309 (link may not be stable)
[32/39] efi: payload: protect against missing state alias
        https://git.pengutronix.de/cgit/barebox/commit/?id=8f813078b96f (link may not be stable)
[33/39] efi: loader: fix stale return value in console out-of-memory path
        https://git.pengutronix.de/cgit/barebox/commit/?id=2c62cc5ef0ab (link may not be stable)
[34/39] efi: loader: fix off-by-one in FAT codepage translation
        https://git.pengutronix.de/cgit/barebox/commit/?id=4e9944e5cd11 (link may not be stable)
[35/39] efi: loader: fix co-existence with EFI payload support
        https://git.pengutronix.de/cgit/barebox/commit/?id=8663727f7d2e (link may not be stable)
[36/39] efi: payload: skip ELF MMU handling when booted via stub
        https://git.pengutronix.de/cgit/barebox/commit/?id=d3a7be5efa53 (link may not be stable)
[37/39] efi: payload: register dummy device tree
        https://git.pengutronix.de/cgit/barebox/commit/?id=10922345fbcc (link may not be stable)
[38/39] console: introduce helper for printing binary buffers as-is
        https://git.pengutronix.de/cgit/barebox/commit/?id=149d4ce8633d (link may not be stable)
[39/39] efi: loader: protocol: console: don't turn LF into CRLF
        https://git.pengutronix.de/cgit/barebox/commit/?id=aff0a2f03766 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




      parent reply	other threads:[~2026-02-23  9:47 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-16  8:44 Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 01/39] efi: fix potential NULL dereference Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 02/39] efi: trace: fix EFI_EXIT2 to not evaluate output value on error Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 03/39] efi: loader: fix CRC32 computation in table header update Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 04/39] efi: loader: fix pointer vs value comparison in free_efi_only Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 05/39] efi: loader: fix disk write return value check Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 06/39] efi: loader: fix EFI_ENTRY/EFI_EXIT ordering in efi_set_time Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 07/39] efi: runtime: fix missing EFI_EXIT in efirt_query_variable_info Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 08/39] efi: loader: fix file handle leak in efi_file_from_path Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 09/39] efi: loader: fix missing field init in deferred protocol add Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 10/39] efi: loader: fix memory leak in efi_var_to_file Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 11/39] efi: loader: fix multiple bugs in efi_loader_bootm Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 12/39] efi: loader: fix return type and memory leak in efi_smbios_register Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 13/39] efi: loader: fix memory leak in efi_dp_split_file_path Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 14/39] efi: loader: fix HII string table realloc and memset bugs Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 15/39] efi: loader: fix format specifier and missing EFI_EXIT in boot services Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 16/39] efi: fix unreachable free in efi_set_variable_printf Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 17/39] efi: payload: fix missing NULL check after read_file in handover Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 18/39] efi: payload: fix EFI page leak in efi_read_file Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 19/39] efi: payload: fix inverted error check after state_load Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 20/39] efi: fix out-of-bounds read in device path unknown node printing Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 21/39] efi: payload: fix wrong page count in efi_unload_fdt Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 22/39] efi: fix out-of-bounds read in 1394 device path printing Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 23/39] efi: loader: initialize block IO ops before installing protocol Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 24/39] efi: runtime: fix variable store bounds check to account for alignment Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 25/39] efi: fix Fibre Channel device path type vs sub_type comparison Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 26/39] efi: loader: fix file open mode always setting O_RDWR Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 27/39] efi: loader: fix NULL pointer dereference when deleting root volume handle Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 28/39] efi: loader: fix memory leak of variable file buffer on success Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 29/39] efi: loader: fix memory leak in efi_var_collect on buffer overflow Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 30/39] efi: fix signed format specifier for uint64_t timestamp Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 31/39] efi: payload: fix possible memory leaks during init Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 32/39] efi: payload: protect against missing state alias Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 33/39] efi: loader: fix stale return value in console out-of-memory path Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 34/39] efi: loader: fix off-by-one in FAT codepage translation Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 35/39] efi: loader: fix co-existence with EFI payload support Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 36/39] efi: payload: skip ELF MMU handling when booted via stub Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 37/39] efi: payload: register dummy device tree Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 38/39] console: introduce helper for printing binary buffers as-is Ahmad Fatoum
2026-02-16  8:44 ` [PATCH master 39/39] efi: loader: protocol: console: don't turn LF into CRLF Ahmad Fatoum
2026-02-23  9:47 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177184003551.196034.5369311725997865056.b4-ty@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox