mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] boot: guard net in global.boot.default behind CONFIG_NET
@ 2026-02-11 10:02 Ahmad Fatoum
  2026-02-23 11:07 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2026-02-11 10:02 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum, 9l

If CONFIG_NET is disabled, there is little reason to have net in
global.boot.default, so omit it in that case.

CONFIG_NET on its own is not sufficient for net to work by default (ifup
and TFTP are needed in the default case), but we don't want to reflect
all the script dependencies in Kconfig.

Reported-by: <9l@9lo.re>
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 common/boot.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/common/boot.c b/common/boot.c
index 78d990f1617e..8679a594bb76 100644
--- a/common/boot.c
+++ b/common/boot.c
@@ -147,7 +147,8 @@ static int init_boot(void)
 			IF_ENABLED(CONFIG_BOOT_DEFAULTS,       "bootsource ")
 			IF_ENABLED(CONFIG_BOOT_DEFAULTS,       "storage.builtin.nonbootsource ")
 			IF_ENABLED(CONFIG_BOOT_DEFAULTS,       "storage.removable.nonbootsource ")
-			"net"
+			IF_ENABLED(CONFIG_NET,                 "net")
+			""
 		);
 
 	globalvar_add_simple_string("boot.default", &global_boot_default);
-- 
2.47.3




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] boot: guard net in global.boot.default behind CONFIG_NET
  2026-02-11 10:02 [PATCH] boot: guard net in global.boot.default behind CONFIG_NET Ahmad Fatoum
@ 2026-02-23 11:07 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2026-02-23 11:07 UTC (permalink / raw)
  To: barebox, Ahmad Fatoum; +Cc: 9l


On Wed, 11 Feb 2026 11:02:51 +0100, Ahmad Fatoum wrote:
> If CONFIG_NET is disabled, there is little reason to have net in
> global.boot.default, so omit it in that case.
> 
> CONFIG_NET on its own is not sufficient for net to work by default (ifup
> and TFTP are needed in the default case), but we don't want to reflect
> all the script dependencies in Kconfig.
> 
> [...]

Applied, thanks!

[1/1] boot: guard net in global.boot.default behind CONFIG_NET
      https://git.pengutronix.de/cgit/barebox/commit/?id=c0a07127f29e (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-02-23 11:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-11 10:02 [PATCH] boot: guard net in global.boot.default behind CONFIG_NET Ahmad Fatoum
2026-02-23 11:07 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox