mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH master] net: am65-cpsw-nuss: fix up PHY mode for fixed RGMII TX delay
Date: Wed, 25 Feb 2026 15:28:51 +0100	[thread overview]
Message-ID: <177202973189.3053674.1686913554304147024.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20260225140256.165703-1-a.fatoum@pengutronix.de>


On Wed, 25 Feb 2026 15:02:49 +0100, Ahmad Fatoum wrote:
> To restore compatibility with newer Linux device trees and fix network
> breakage on Beagleplay, import following U-Boot commit:
> 
> | commit 4b10bcfdef9cb544ca80988fe36d307a622bcd21
> | Author:     Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> | AuthorDate: Tue Sep 30 10:05:11 2025 +0200
> | Commit:     Tom Rini <trini@konsulko.com>
> | CommitDate: Fri Oct 10 11:07:44 2025 -0600
> |
> |     net: ethernet: ti: am65-cpsw: fix up PHY mode for fixed RGMII TX delay
> |
> |     The am65-cpsw driver currently sets the SEL_RGMII_IDMODE flag in a MAC's
> |     mode register to enable or disable the TX delay. While this was supported
> |     for earlier generations of the CPSW controller, the datasheets of all
> |     modern TI SoCs using the am65-cpsw MAC state that the TX delay is fixed,
> |     and the SEL_RGMII_IDMODE bit is documented as reserved in most of them.
> |     Furthermore, while it was found that this bit does in fact disable the TX
> |     delay, [1] states that this setting is truly unsupported by TI and not
> |     just undocumented.
> |
> |     Following the clarification of the rgmii* phy-mode values in the Linux
> |     DT bindings in [2], the Linux am65-cpsw driver was changed in [3] to
> |     account for the fixed TX delay by fixing up the mode passed to the PHY
> |     driver; a similar fixup already existed in the TI icssg-prueth driver.
> |     [4] followed up on this by explicitly clearing the SEL_RGMII_IDMODE flag
> |     to handle the case where it is set by the bootloader or other firmware
> |     before Linux.
> |
> |     With the above changes, Device Trees that set the recommended "rgmii-id"
> |     mode are now appearing in Linux 6.17+. Avoid setting the unsupported
> |     SEL_RGMII_IDMODE flag for such Device Trees, and instead fix up the PHY
> |     interface mode, thus aligning the U-Boot driver with the Linux kernel.
> |
> |     [1] https://www.spinics.net/lists/netdev/msg1112647.html
> |     [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c360eb0c3ccb95306704fd221442283ee82f1f58
> |     [3] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ca13b249f291f4920466638d1adbfb3f9c8db6e9
> |     [4] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a22d3b0d49d411e64ed07e30c2095035ecb30ed2
> |
> |     Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> 
> [...]

Applied, thanks!

[1/1] net: am65-cpsw-nuss: fix up PHY mode for fixed RGMII TX delay
      https://git.pengutronix.de/cgit/barebox/commit/?id=810120e81a95 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




      reply	other threads:[~2026-02-25 14:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25 14:02 Ahmad Fatoum
2026-02-25 14:28 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177202973189.3053674.1686913554304147024.b4-ty@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox