* [PATCH master] Makefile: pass KBUILD_OUTPUT to pytest in check target
@ 2026-03-02 13:50 Ahmad Fatoum
2026-03-04 7:34 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2026-03-02 13:50 UTC (permalink / raw)
To: barebox; +Cc: Ahmad Fatoum
The check target runs pytest from the source directory, but doesn't
propagate the build output directory. conftest.py falls back to
using build/ if it exists, which may contain a completely different
configuration.
Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 28f450ee7cd7..e62965d4c1c8 100644
--- a/Makefile
+++ b/Makefile
@@ -1083,7 +1083,7 @@ endif
fi
@echo
@# This is intentionally not @suppressed, to make it easier to reproduce
- (cd $(srctree); $(PYTEST))
+ (cd $(srctree); KBUILD_OUTPUT=$(abs_objtree) $(PYTEST))
PHONY += check
--
2.47.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH master] Makefile: pass KBUILD_OUTPUT to pytest in check target
2026-03-02 13:50 [PATCH master] Makefile: pass KBUILD_OUTPUT to pytest in check target Ahmad Fatoum
@ 2026-03-04 7:34 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2026-03-04 7:34 UTC (permalink / raw)
To: barebox, Ahmad Fatoum
On Mon, 02 Mar 2026 14:50:03 +0100, Ahmad Fatoum wrote:
> The check target runs pytest from the source directory, but doesn't
> propagate the build output directory. conftest.py falls back to
> using build/ if it exists, which may contain a completely different
> configuration.
>
>
Applied, thanks!
[1/1] Makefile: pass KBUILD_OUTPUT to pytest in check target
https://git.pengutronix.de/cgit/barebox/commit/?id=88c39fa118a6 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-04 7:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-02 13:50 [PATCH master] Makefile: pass KBUILD_OUTPUT to pytest in check target Ahmad Fatoum
2026-03-04 7:34 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox