From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@barebox.org>
Subject: Re: [PATCH] param: return error when assigning empty string
Date: Mon, 11 May 2026 09:15:30 +0200 [thread overview]
Message-ID: <177848373003.3154785.16125083638500333558.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20260507114919.1366520-1-a.fatoum@barebox.org>
On Thu, 07 May 2026 13:49:18 +0200, Ahmad Fatoum wrote:
> The fallback path that allows specifying enum values by index returns an
> error if *endp != '\0' to account for invalid values like my.enum.param=1z.
>
> This fails to account for the corner case of the empty string which
> would also have *endp == '\0; with idx being the default 0.
>
> Check for that explicitly and return an error.
>
> [...]
Applied, thanks!
[1/1] param: return error when assigning empty string
https://git.pengutronix.de/cgit/barebox/commit/?id=fb0edacd3624 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2026-05-11 7:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 11:49 Ahmad Fatoum
2026-05-11 7:15 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177848373003.3154785.16125083638500333558.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@barebox.org \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox