From: Sascha Hauer <s.hauer@pengutronix.de>
To: BAREBOX <barebox@lists.infradead.org>,
Jonas Rebmann <jre@pengutronix.de>
Subject: Re: [PATCH v2 0/2] input: Supersede input_key_get_status() with input_is_key_pressed()
Date: Mon, 11 May 2026 09:26:51 +0200 [thread overview]
Message-ID: <177848441189.3155506.13730172111558691204.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20260507-input_is_key_pressed-v2-0-3c43453a199d@pengutronix.de>
On Thu, 07 May 2026 15:48:22 +0200, Jonas Rebmann wrote:
> Reading a GPIO button via gpio-keys can be preferable over direct GPIO
> access as gpio-keys abstracts away from GPIO hardware via the
> devicetree, consistently across barebox and linux.
>
> Trying to read a single key state analogous to prt_imx6_init_prtvt7
> failed as input_key_get_status should have been provided with the
> keycode in question plus one to ensure a large enough bitfield to
> contain the desired key state.
>
> [...]
Applied, thanks!
[1/2] input: add input_is_key_pressed() to read single key
https://git.pengutronix.de/cgit/barebox/commit/?id=aa1b345ec9fc (link may not be stable)
[2/2] ARM: boards: protonic-imx6: use input_is_key_pressed()
https://git.pengutronix.de/cgit/barebox/commit/?id=949c0d352eb3 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2026-05-11 7:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 13:48 Jonas Rebmann
2026-05-07 13:48 ` [PATCH v2 1/2] input: add input_is_key_pressed() to read single key Jonas Rebmann
2026-05-07 13:48 ` [PATCH v2 2/2] ARM: boards: protonic-imx6: use input_is_key_pressed() Jonas Rebmann
2026-05-11 7:26 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177848441189.3155506.13730172111558691204.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jre@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox