From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 02 Jul 2026 13:08:17 +0200 Received: from mx1.white.stw.pengutronix.de ([185.203.200.13]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wfFHF-00CEvL-28 for lore@lore.pengutronix.de; Thu, 02 Jul 2026 13:08:17 +0200 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by mx1.white.stw.pengutronix.de (Postfix) with ESMTPS id 73B58200A6D for ; Thu, 02 Jul 2026 13:08:17 +0200 (CEST) Authentication-Results: mx1.white.stw.pengutronix.de; dkim=pass header.d=lists.infradead.org header.s=bombadil.20210309 header.b=ATyMaKyq; spf=pass (mx1.white.stw.pengutronix.de: domain of "barebox-bounces+lore=pengutronix.de@lists.infradead.org" designates 2607:7c80:54:3::133 as permitted sender) smtp.mailfrom="barebox-bounces+lore=pengutronix.de@lists.infradead.org"; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Date:Message-Id:Subject:References:In-Reply-To:To: From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+PJilQTZ4S5ZbcA48IDvJ1jXUdceIUmzKzVVLsV6M74=; b=ATyMaKyqAfhb+srA+7fd8Rzyip cKVVLdr9UBi0u82GbgMA0A/ATh110eWRFwTO8Fwehcz1xYNXZ4tGr6Vbg2Ne9CP6pukdOjsH8DMH4 i35Z0wPKMb7llCTv0fArj6R+KmmagSw4tSa9fYm+k33szjVj+vUy0pR5/PaJBrRKtkG0uU2NfiAUc rDfOVtPI1GJS6V/iW5DDHlyjRQYcBG0Z94er1057yhuy/pMsUrUXHAtDA7zmhBYVOP6BYCOwkQG6C 5urBEGzC+7fTj+RStnxNDEpQeSGJhtjg+ab+WhUIJIW3tTxU9cOv9qj4TVQanfh8bVG2b2Y7aT8p6 QyorKIsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfCJr-00000003mxp-0tJm; Thu, 02 Jul 2026 07:58:47 +0000 Received: from mx1.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::107]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfCJn-00000003mwo-3yFm for barebox@lists.infradead.org; Thu, 02 Jul 2026 07:58:46 +0000 Received: from drehscheibe.grey.stw.pengutronix.de (drehscheibe.grey.stw.pengutronix.de [IPv6:2a0a:edc0:0:c01:1d::a2]) (Authenticated sender: relay-from-drehscheibe.grey.stw.pengutronix.de) by mx1.white.stw.pengutronix.de (Postfix) with ESMTPSA id 06B0D200498; Thu, 02 Jul 2026 09:58:42 +0200 (CEST) Received: from dude02.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::28]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wfCJl-005i7G-33; Thu, 02 Jul 2026 09:58:41 +0200 Received: from [::1] (helo=dude02.red.stw.pengutronix.de) by dude02.red.stw.pengutronix.de with esmtp (Exim 4.98.2) (envelope-from ) id 1wfCJl-00000008cbi-3hbr; Thu, 02 Jul 2026 09:58:41 +0200 From: Sascha Hauer To: barebox@lists.infradead.org, Marco Felsch In-Reply-To: <20260622172121.1736295-1-m.felsch@pengutronix.de> References: <20260622172121.1736295-1-m.felsch@pengutronix.de> Subject: Re: [PATCH] restart: fix restart handler by name selection Message-Id: <178297912187.2055009.11092772544009580532.b4-ty@pengutronix.de> Date: Thu, 02 Jul 2026 09:58:41 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260702_005844_139187_30F7A855 X-CRM114-Status: UNSURE ( 7.85 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.9 (-) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Mon, 22 Jun 2026 19:21:19 +0200, Marco Felsch wrote: > Commit d20a9a455d8d ("restart: allow selecting restart handler by device > name") introduce a bug, while adding the support to select a resta [...] Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 DMARC_MISSING Missing DMARC policy X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-Rspamd-Queue-Id: 73B58200A6D X-Spamd-Result: default: False [-6.71 / 15.00]; BAYES_HAM(-3.00)[99.99%]; DWL_DNSWL_MED(-2.00)[infradead.org:dkim]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; RCVD_IN_DNSWL_MED(-0.40)[2a0a:edc0:0:1101:1d::28:received,2607:7c80:54:3::133:from]; R_DKIM_ALLOW(-0.20)[lists.infradead.org:s=bombadil.20210309]; R_SPF_ALLOW(-0.20)[+mx:c]; MAILLIST(-0.20)[mailman]; MIME_GOOD(-0.10)[text/plain]; RCVD_IN_DNSWL_LOW(-0.10)[2a0a:edc0:0:c01:1d::a2:received]; HAS_LIST_UNSUB(-0.01)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; ARC_NA(0.00)[]; RECEIVED_HELO_LOCALHOST(0.00)[]; DMARC_NA(0.00)[pengutronix.de]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[lists.infradead.org:+]; ASN(0.00)[asn:7247, ipnet:2607:7c80:54::/48, country:US]; FROM_NEQ_ENVFROM(0.00)[s.hauer@pengutronix.de,barebox-bounces@lists.infradead.org]; FROM_HAS_DN(0.00)[]; TAGGED_FROM(0.00)[lore=pengutronix.de]; RCVD_COUNT_FIVE(0.00)[5]; MID_RHS_MATCH_FROM(0.00)[]; NEURAL_HAM(-0.00)[-1.000]; RCVD_VIA_SMTP_AUTH(0.00)[]; FORGED_SENDER_MAILLIST(0.00)[] X-Rspamd-Action: no action X-Stat-Signature: fk3w5r5my6dkt8daqafi1868u45njiqs X-Rspamd-Server: mx1 On Mon, 22 Jun 2026 19:21:19 +0200, Marco Felsch wrote: > Commit d20a9a455d8d ("restart: allow selecting restart handler by device > name") introduce a bug, while adding the support to select a restart > handler by device name. > > The list_for_each_entry() loop should sort out all restart handler which > don't match the user requested restart handler. Instead all restart > handlers which don't have a device associated are honored as well > because the if condition is always 0 in this case. > > [...] Applied, thanks! [1/1] restart: fix restart handler by name selection https://git.pengutronix.de/cgit/barebox/commit/?id=8bd9cab774e9 (link may not be stable) Best regards, -- Sascha Hauer