From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 10 Jul 2026 23:36:25 +0200 Received: from mx1.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::107]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wiItV-002NlS-14 for lore@lore.pengutronix.de; Fri, 10 Jul 2026 23:36:25 +0200 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by mx1.white.stw.pengutronix.de (Postfix) with ESMTPS id 28944200668 for ; Fri, 10 Jul 2026 23:36:25 +0200 (CEST) Authentication-Results: mx1.white.stw.pengutronix.de; dkim=pass header.d=lists.infradead.org header.s=bombadil.20210309 header.b=DWFga3nH; spf=pass (mx1.white.stw.pengutronix.de: domain of "barebox-bounces+lore=pengutronix.de@lists.infradead.org" designates 2607:7c80:54:3::133 as permitted sender) smtp.mailfrom="barebox-bounces+lore=pengutronix.de@lists.infradead.org"; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Date:Message-Id:Subject:References:In-Reply-To:To: From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Za1/SBW6kTWnYXGjUcCjXhYF+duaKxiQrgo1cPf55Qc=; b=DWFga3nHtDNr+xYcrsGYl+x3i2 fwqkfnjNNxJfDZP7SMV92vdH/r0+re7ML42ZsyU/cvBeJphw//Z2IxII/74cCg1oirZqrTHJ1Ebrm ftBLwqCAF60f57R4kj6hXxX9yyRzTVwR8GOAPdxCSKu0bx9uY95uTJb/6frLjA27W5/b3AVgPsR62 tFFpDbQNwFM+iVJZS0thOaCQo9tiZZRwIOW9NbGR5kFHN+vOQ/kM4nHbFE05nneKiXdEr3amVPpk6 EU6njASNCc5yqKuxS8wTrQmw0vBP1eiNczNsW+N30oixM5jyaZ0F8fb/OID49O+lmxb6LWRPHFqiV /4jx4GeQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wiIsW-00000005rSL-4BhB; Fri, 10 Jul 2026 21:35:25 +0000 Received: from mx1.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::107]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wiIsU-00000005rRW-2q1H for barebox@lists.infradead.org; Fri, 10 Jul 2026 21:35:24 +0000 Received: from drehscheibe.grey.stw.pengutronix.de (drehscheibe.grey.stw.pengutronix.de [IPv6:2a0a:edc0:0:c01:1d::a2]) (Authenticated sender: relay-from-drehscheibe.grey.stw.pengutronix.de) by mx1.white.stw.pengutronix.de (Postfix) with ESMTPSA id 0DF5B20201F; Fri, 10 Jul 2026 23:35:21 +0200 (CEST) Received: from dude02.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::28]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wiIsS-0018qK-39; Fri, 10 Jul 2026 23:35:20 +0200 Received: from [::1] (helo=dude02.red.stw.pengutronix.de) by dude02.red.stw.pengutronix.de with esmtp (Exim 4.98.2) (envelope-from ) id 1wiIsS-0000000ErVZ-3pqx; Fri, 10 Jul 2026 23:35:20 +0200 From: Sascha Hauer To: barebox@lists.infradead.org, Ahmad Fatoum In-Reply-To: <20260709134111.3314089-1-a.fatoum@pengutronix.de> References: <20260709134111.3314089-1-a.fatoum@pengutronix.de> Subject: Re: [PATCH] dma: return NULL on dma_alloc_coherent failure Message-Id: <178371932090.3542258.1570601136067314894.b4-ty@pengutronix.de> Date: Fri, 10 Jul 2026 23:35:20 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260710_143523_146534_E7F88816 X-CRM114-Status: UNSURE ( 7.72 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.9 (-) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Thu, 09 Jul 2026 15:41:05 +0200, Ahmad Fatoum wrote: > The majority of our calls to dma_alloc_coherent check for a NULL return > that would indicate an error as that's the Linux API as well. > > I [...] Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 DMARC_MISSING Missing DMARC policy X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-Spamd-Result: default: False [-6.61 / 15.00]; BAYES_HAM(-3.00)[99.99%]; DWL_DNSWL_MED(-2.00)[infradead.org:dkim]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; RCVD_IN_DNSWL_MED(-0.40)[2a0a:edc0:0:1101:1d::28:received,2607:7c80:54:3::133:from]; R_DKIM_ALLOW(-0.20)[lists.infradead.org:s=bombadil.20210309]; R_SPF_ALLOW(-0.20)[+mx:c]; MAILLIST(-0.20)[mailman]; MIME_GOOD(-0.10)[text/plain]; HAS_LIST_UNSUB(-0.01)[]; RCVD_COUNT_FIVE(0.00)[5]; RCPT_COUNT_TWO(0.00)[2]; DMARC_NA(0.00)[pengutronix.de]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RECEIVED_HELO_LOCALHOST(0.00)[]; RCVD_TLS_LAST(0.00)[]; TAGGED_FROM(0.00)[lore=pengutronix.de]; MID_RHS_MATCH_FROM(0.00)[]; NEURAL_HAM(-0.00)[-1.000]; FROM_NEQ_ENVFROM(0.00)[s.hauer@pengutronix.de,barebox-bounces@lists.infradead.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; DKIM_TRACE(0.00)[lists.infradead.org:+]; ASN(0.00)[asn:7247, ipnet:2607:7c80:54::/48, country:US]; RCVD_IN_DNSWL_NONE(0.00)[2a0a:edc0:0:c01:1d::a2:received]; FORGED_SENDER_MAILLIST(0.00)[] X-Rspamd-Action: no action X-Rspamd-Server: mx1 X-Rspamd-Queue-Id: 28944200668 X-Stat-Signature: 877rrgqg6mdsqwc7mxkbm1bzz4hojbsg On Thu, 09 Jul 2026 15:41:05 +0200, Ahmad Fatoum wrote: > The majority of our calls to dma_alloc_coherent check for a NULL return > that would indicate an error as that's the Linux API as well. > > In barebox, dma_alloc_coherent panics though. This mostly doesn't matter, > because these are mostly fixed size allocations at driver probe time, > but we have some older code like the Freescale UDC driver that allocates > coherent memory out of a poller context. > > [...] Applied, thanks! [1/1] dma: return NULL on dma_alloc_coherent failure https://git.pengutronix.de/cgit/barebox/commit/?id=467f5e1cc300 (link may not be stable) Best regards, -- Sascha Hauer