From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 10 Jul 2026 23:51:12 +0200 Received: from mx1.white.stw.pengutronix.de ([185.203.200.13]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wiJ7o-002O0C-08 for lore@lore.pengutronix.de; Fri, 10 Jul 2026 23:51:12 +0200 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by mx1.white.stw.pengutronix.de (Postfix) with ESMTPS id D370F202029 for ; Fri, 10 Jul 2026 23:51:11 +0200 (CEST) Authentication-Results: mx1.white.stw.pengutronix.de; dkim=pass header.d=lists.infradead.org header.s=bombadil.20210309 header.b=HJUYZ5Bb; spf=pass (mx1.white.stw.pengutronix.de: domain of "barebox-bounces+lore=pengutronix.de@lists.infradead.org" designates 2607:7c80:54:3::133 as permitted sender) smtp.mailfrom="barebox-bounces+lore=pengutronix.de@lists.infradead.org"; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Date:Message-Id:Subject:References:In-Reply-To:To: From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bFmH7OblWKD50ePjPe3PaFMSMlJZS7g6+J3DFH0+XDo=; b=HJUYZ5Bb/DyuA26TgC9wOWO3uA f6pephi8UPZKVIvP2N6GIkdnU0GW2UfZq/jYHIMeQ9zzTIizCJ+BJ3BT3syaBDALLE1CdurhWZSXd Ex7jLVIIhzWnGrDoUIFAe3pQTBPeqQcj53BqWWXUipluWxZQ83y2LS8704q2AzZEAlF4esT+y8MIj AGedtD8fS7a1CZYQqNJPgeGxsueq0PF5IrBW+iUSDEykr1Dmkn9+noApJAHcVY7vKqdR/dSVjUX5g QLUHpFJr2Qef+BAq7FJkfEtJ0O/38xPMWb04vZQWA5HsNS+OOBix0pw1P00aG+d3UTcvh4hN+TR+h aGfLy/PA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wiJ6r-00000005skE-1e3G; Fri, 10 Jul 2026 21:50:13 +0000 Received: from mx1.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::107]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wiJ6p-00000005sjm-0HCJ for barebox@lists.infradead.org; Fri, 10 Jul 2026 21:50:12 +0000 Received: from drehscheibe.grey.stw.pengutronix.de (drehscheibe.grey.stw.pengutronix.de [IPv6:2a0a:edc0:0:c01:1d::a2]) (Authenticated sender: relay-from-drehscheibe.grey.stw.pengutronix.de) by mx1.white.stw.pengutronix.de (Postfix) with ESMTPSA id 1BEAB202029; Fri, 10 Jul 2026 23:50:09 +0200 (CEST) Received: from dude02.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::28]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wiJ6n-0018ri-06; Fri, 10 Jul 2026 23:50:09 +0200 Received: from [::1] (helo=dude02.red.stw.pengutronix.de) by dude02.red.stw.pengutronix.de with esmtp (Exim 4.98.2) (envelope-from ) id 1wiJ6m-0000000EtIG-45Rz; Fri, 10 Jul 2026 23:50:08 +0200 From: Sascha Hauer To: barebox@lists.infradead.org, Ahmad Fatoum In-Reply-To: <20260709074429.534460-1-a.fatoum@barebox.org> References: <20260709074429.534460-1-a.fatoum@barebox.org> Subject: Re: [PATCH] efi: fix GetNextDevicePathInstance trace argument Message-Id: <178372020897.3549113.15676890493407812817.b4-ty@pengutronix.de> Date: Fri, 10 Jul 2026 23:50:08 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260710_145011_285313_CF2422FA X-CRM114-Status: UNSURE ( 7.08 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.9 (-) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Thu, 09 Jul 2026 09:44:28 +0200, Ahmad Fatoum wrote: > Verbose EFI tracing formats device paths with %pD. The > GetNextDevicePathInstance wrapper receives an EFI_DEVICE_PATH **, but passed > that [...] Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 DMARC_MISSING Missing DMARC policy X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-Spamd-Result: default: False [-6.61 / 15.00]; BAYES_HAM(-3.00)[99.99%]; DWL_DNSWL_MED(-2.00)[infradead.org:dkim]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; RCVD_IN_DNSWL_MED(-0.40)[2607:7c80:54:3::133:from,2a0a:edc0:0:1101:1d::28:received]; R_SPF_ALLOW(-0.20)[+mx:c]; MAILLIST(-0.20)[mailman]; R_DKIM_ALLOW(-0.20)[lists.infradead.org:s=bombadil.20210309]; MIME_GOOD(-0.10)[text/plain]; HAS_LIST_UNSUB(-0.01)[]; DMARC_NA(0.00)[pengutronix.de]; RECEIVED_HELO_LOCALHOST(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_FIVE(0.00)[5]; TAGGED_FROM(0.00)[lore=pengutronix.de]; FROM_NEQ_ENVFROM(0.00)[s.hauer@pengutronix.de,barebox-bounces@lists.infradead.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; NEURAL_HAM(-0.00)[-1.000]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:7247, ipnet:2607:7c80:54::/48, country:US]; DKIM_TRACE(0.00)[lists.infradead.org:+]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2a0a:edc0:0:c01:1d::a2:received]; FORGED_SENDER_MAILLIST(0.00)[] X-Rspamd-Action: no action X-Rspamd-Server: mx1 X-Rspamd-Queue-Id: D370F202029 X-Stat-Signature: 7tsojmtikkomfpygmsb83gjsz3yk648b On Thu, 09 Jul 2026 09:44:28 +0200, Ahmad Fatoum wrote: > Verbose EFI tracing formats device paths with %pD. The > GetNextDevicePathInstance wrapper receives an EFI_DEVICE_PATH **, but passed > that pointer slot directly to %pD. When the SCT called the service, the trace > formatter interpreted stack bytes as a device path and could loop before the > service body was reached. > > Log the pointed-to device path when the argument itself is present. This keeps > the trace useful while avoiding a tracing-induced hang during the Device Path > Utilities ACS coverage. > > [...] Applied, thanks! [1/1] efi: fix GetNextDevicePathInstance trace argument https://git.pengutronix.de/cgit/barebox/commit/?id=294a67a596fb (link may not be stable) Best regards, -- Sascha Hauer