From: "Clément Leger" <cleger@kalray.eu>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] kvx: exclude dtb from malloc zone
Date: Mon, 3 Aug 2020 08:51:42 +0200 (CEST) [thread overview]
Message-ID: <1787980069.3870762.1596437502890.JavaMail.zimbra@kalray.eu> (raw)
In-Reply-To: <1672417604.1973524.1594462778349.JavaMail.zimbra@kalray.eu>
Hi Sascha,
----- On 11 Jul, 2020, at 12:19, Clément Leger cleger@kalray.eu wrote:
> Hi Sascha
>
> ----- On 11 Jul, 2020, at 06:41, Sascha Hauer s.hauer@pengutronix.de wrote:
>
>> Hi Clement,
>>
>> On Thu, Jul 09, 2020 at 10:22:04PM +0200, Clement Leger wrote:
>>> When dtb is provided by the FSBL (first stage bootloader), it might
>>> end up in the malloc zone initialized by barebox. While the dtb is
>>> discarded after being unflatten, if the dtb is provided right after
>>> barebox elf, then the malloc can overwrite it while unflattening it when
>>> allocating nodes.
>>> To avoid that, exclude the dtb from the malloc zone by checking if it
>>> overlaps it. If so, determine the largest zone for the allocation and
>>> modify the memory area to use that.
>>
>> Isn't there some safe place where the dtb can be copied to? Making the
>> malloc area smaller seems a bit wasteful.
>
> Currently, the FSBL now always put the dtb after the barebox elf which lead
> to a minimal impact on the malloc zone (~3Gib) malloc area since barebox runs
> in DDR.
>
> We could reserve some space in barebox to recopy the dtb early after boot
> before setting up the malloc. However, what size should it be to accomodate
> all devices trees ? We could also copy it in smem but since the kvx barebox
> port is memory agnostic (ie can run in either SMEM or DDR), I'm not sure
> this is future proof.
> Do you have any other idea ?
Do you have any additionnal comments on this one ?
Thanks,
Clément
>
> Thanks,
>
> Clément
>
>>
>> Sascha
>>
>> --
>> Pengutronix e.K. | |
>> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
>> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
>> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-08-03 6:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 20:22 Clement Leger
2020-07-11 4:41 ` Sascha Hauer
2020-07-11 10:19 ` Clément Leger
2020-08-03 6:51 ` Clément Leger [this message]
2020-08-11 7:34 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1787980069.3870762.1596437502890.JavaMail.zimbra@kalray.eu \
--to=cleger@kalray.eu \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox