From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Bo Shen <voice.shen@atmel.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: atmel: sama5d3xek: fix conflict between w1 and led
Date: Fri, 23 Jan 2015 17:18:05 +0800 [thread overview]
Message-ID: <1A8441EE-39E2-4C69-AB34-C7B7D14412D1@jcrosoft.com> (raw)
In-Reply-To: <54C207DD.9060201@atmel.com>
> On Jan 23, 2015, at 4:35 PM, Bo Shen <voice.shen@atmel.com> wrote:
>
> Hi J,
>
> On 01/23/2015 03:58 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
>>
>>> On Jan 21, 2015, at 6:03 PM, Bo Shen <voice.shen@atmel.com> wrote:
>>>
>>> Hi J,
>>>
>>> On 01/21/2015 05:56 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
>>>>
>>>>> On Jan 21, 2015, at 5:41 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
>>>>>
>>>>> On Tue, Jan 20, 2015 at 03:31:25PM +0800, Bo Shen wrote:
>>>>>> As the 1-wire and LED d2 use the same pin (PE25) on the EK board.
>>>>>> So, make LED enable only when the 1-wire is disabled.
>>>>>>
>>>>>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>>>>>> ---
>>>>>>
>>>>>> arch/arm/boards/sama5d3xek/init.c | 8 ++++++++
>>>>>> 1 file changed, 8 insertions(+)
>>>>>
>>>>
>>>> On barebox this does not conflict
>>>
>>> As both use gpio mode, which will call gpio request, when LED try to request the same gpio, it will failed. So, the led d2 won't be successfully registered.
>>
>> Yes with the pinctrl driver
>>
>> but it will be a choice at defconfig level not C code
>>
>> if you enable both we need to put a warning at compiling time
>
> I don't find any good solution for this, can you provide one? Thanks.
>
>> and decide which one is more important because if you do not use the w1 you may do except to have both legs
>
> Actually, in code, no use for led d2, only d1 heart beat.
>
Will take a look next week
Best Regards,
J.
>>
>>>
>>>> as we do not have multi task support
>>>>
>>>> Best Regards,
>>>> J.
>>>>> Applied, thanks
>>>>>
>>>>> Sascha
>>>>>
>>>>>
>>>>> --
>>>>> Pengutronix e.K. | |
>>>>> Industrial Linux Solutions | http://www.pengutronix.de/ |
>>>>> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
>>>>> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>>>>
>>>
>>> Best Regards,
>>> Bo Shen
>>
>
> Best Regards,
> Bo Shen
>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2015-01-23 9:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 7:31 Bo Shen
2015-01-21 9:41 ` Sascha Hauer
2015-01-21 9:56 ` Jean-Christophe PLAGNIOL-VILLARD
2015-01-21 10:03 ` Bo Shen
2015-01-23 7:58 ` Jean-Christophe PLAGNIOL-VILLARD
2015-01-23 8:35 ` Bo Shen
2015-01-23 9:18 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1A8441EE-39E2-4C69-AB34-C7B7D14412D1@jcrosoft.com \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox