From: Bastian Krause <bst@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>, barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] scripts: imx-usb-loader: print USB VID/PID of excluded devices
Date: Fri, 30 Apr 2021 13:53:35 +0200 [thread overview]
Message-ID: <1a0b3e31-6606-44a9-a66c-0b94a556fba4@pengutronix.de> (raw)
In-Reply-To: <fbfe039a-d803-e0eb-8ea2-91229a6541e1@pengutronix.de>
On 4/30/21 11:47 AM, Ahmad Fatoum wrote:
>
> On 30.04.21 11:19, Bastian Krause wrote:
>> On hosts with multiple USB devices connected, multiple "excluded by
>> device path option" messages can be observed. Add the USB VID/PID to
>> these messages to give them some additional value.
>>
>> Signed-off-by: Bastian Krause <bst@pengutronix.de>
>> ---
>> scripts/imx/imx-usb-loader.c | 11 +++++++++--
>> 1 file changed, 9 insertions(+), 2 deletions(-)
>>
>> diff --git a/scripts/imx/imx-usb-loader.c b/scripts/imx/imx-usb-loader.c
>> index 6f9104e816..765ba61310 100644
>> --- a/scripts/imx/imx-usb-loader.c
>> +++ b/scripts/imx/imx-usb-loader.c
>> @@ -312,10 +312,17 @@ static int device_location_equal(libusb_device *device, const char *location)
>> };
>>
>> /* walked the full path, all elements match */
>> - if (path_step == path_len)
>> + if (path_step == path_len) {
>> result = 1;
>> - else if (verbose)
>> + } else if (verbose) {
>> + struct libusb_device_descriptor desc;
>> +
>> + if (!libusb_get_device_descriptor(device, &desc));
>> + fprintf(stderr, "USB device [%04x:%04x]",
>> + desc.idVendor, desc.idProduct);
>> +
>> fprintf(stderr, " excluded by device path option\n");
>
> find_imx_dev already does libusb_get_device_descriptor(), so you could
> pass along the desc and print it here instead of asking for it again?
Sure, will send a v2.
Bastian
>
>> + }
>>
>> done:
>> free(loc);
>>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-04-30 11:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 9:19 [PATCH 1/2] scripts: imx-usb-loader: print excluded USB device message only on verbose Bastian Krause
2021-04-30 9:19 ` [PATCH 2/2] scripts: imx-usb-loader: print USB VID/PID of excluded devices Bastian Krause
2021-04-30 9:47 ` Ahmad Fatoum
2021-04-30 11:53 ` Bastian Krause [this message]
2021-04-30 9:44 ` [PATCH 1/2] scripts: imx-usb-loader: print excluded USB device message only on verbose Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a0b3e31-6606-44a9-a66c-0b94a556fba4@pengutronix.de \
--to=bst@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox