Re: [PATCH] commands: of_display_timings: Add simple-panel support

["Stefan Riedmüller" <s.riedmueller@phytec.de>]

Hi Sascha,

On 02.05.2018 12:49, Sascha Hauer wrote:
> Hi Stefan,
>
> On Fri, Apr 20, 2018 at 01:01:01PM +0200, Stefan Riedmueller wrote:
>> Display timings can now be set with simple-panel method which selects
>> the required timings by the compatible of the simple panel devicetree
>> node.
>>
>> This patch adds an option to set simple panel timings with the
>> of_display_timings command by setting the compatible of the display node.
>> The options -P and -c were implemented. The -P option requires the display
>> node path as argument and the -c option requires the compatible to set.
>>
>> This has one downside. The available simple panel timings cannot be
>> listed since the timings are defined in the kernel. Account for this in the
>> help text.
>>
>> Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
>> ---
>>   commands/of_display_timings.c | 65 ++++++++++++++++++++++++++++++++++++++++---
>>   1 file changed, 61 insertions(+), 4 deletions(-)
> This patch seems to be a way to manipulate a device tree property in the
> Linux device tree. How about adding a new option to the of_property
> command which would register a of_fixup instead of doing the operation
> now?
>
> Like this:
>
> of_property -f -s /path/to/node compatible vendor,foo-display

Thats a good idea. My intention was to put it in of_display_timings 
because it is display timing related but I see the advantage of having a 
more generic solution for this. So I put it on my todo and try to send a 
patch soon.

Thanks
Stefan

>
>> +		case 'c':
>> +			compatible = optarg;
>> +			break;
>>   		case 'S':
>>   			timingpath = xzalloc(strlen(optarg) + 1);
>>   			strcpy(timingpath, optarg);
> xstrdup() is what you want here.
>
> Sascha
>

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox