Re: [PATCH 14/14] ARM: i.MX: tqma6ulx: use ENTRY_FUNCTION_WITHSTACK

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 6/27/25 16:08, Sascha Hauer wrote:
> The first thing the tqma6ulx lowlevel code does is setting up the stack.
> Use ENTRY_FUNCTION_WITHSTACK() which is specifically for this purpose.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

> ---
>  arch/arm/boards/tqma6ulx/lowlevel.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boards/tqma6ulx/lowlevel.c b/arch/arm/boards/tqma6ulx/lowlevel.c
> index da67e67537167096477de2b905ee5c42c653c3af..57639f8a84e7680c4ee0608abf31ae8b6f1cfd28 100644
> --- a/arch/arm/boards/tqma6ulx/lowlevel.c
> +++ b/arch/arm/boards/tqma6ulx/lowlevel.c
> @@ -92,13 +92,10 @@ static void noinline start_mba6ulx(void)
>  	imx6ul_barebox_entry(fdt);
>  }
>  
> -ENTRY_FUNCTION(start_imx6ul_mba6ulx, r0, r1, r2)
> +ENTRY_FUNCTION_WITHSTACK(start_imx6ul_mba6ulx, 0x00910000, r0, r1, r2)
>  {
> -
>  	imx6ul_cpu_lowlevel_init();
>  
> -	arm_setup_stack(0x00910000);
> -
>  	if (IS_ENABLED(CONFIG_DEBUG_LL)) {
>  		imx6_uart_setup_ll();
>  		putc_ll('>');
> 

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |