mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Alexander Shiyan <eagle.alexander923@gmail.com>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] ARM: DTS: myir-x335x: Add GPIO aliases
Date: Wed, 25 May 2022 10:16:13 +0200	[thread overview]
Message-ID: <1db17488-d759-712a-6014-8d2cde412474@pengutronix.de> (raw)
In-Reply-To: <CAP1tNvQVWjG1=jsJRh-eCpHzUPOct1BysgXQy-MxDvYkHFY6wg@mail.gmail.com>

On 25.05.22 08:27, Alexander Shiyan wrote:
> Hello.
> 
> вт, 24 мая 2022 г. в 15:28, Ahmad Fatoum <a.fatoum@pengutronix.de>:
>> On 24.05.22 09:30, Alexander Shiyan wrote:
>>> For the correct work of GPIO driver, we need to define aliases.
>>> Let's add them to the devicetree.
> ...
>>> diff --git a/arch/arm/dts/am335x-myirtech-myd.dts b/arch/arm/dts/am335x-myirtech-myd.dts
>>> index 6ec65e533d..1ea0f2a440 100644
>>> --- a/arch/arm/dts/am335x-myirtech-myd.dts
>>> +++ b/arch/arm/dts/am335x-myirtech-myd.dts
>>> @@ -6,6 +6,13 @@
>>>  #include <arm/am335x-myirtech-myd.dts>
>>
>> Other boards do #include "am33xx.dtsi", which takes care of these
>> aliases. It's probably better you include that too.
> 
> Including this file results in an error.
> 
> Changed to:
> #include "am33xx.dtsi"
> #include <arm/am335x-myirtech-myd.dts>
> 
> Output:
> DTC     arch/arm/dts/am335x-myirtech-myd.dtb
> Error: /home/ARM/barebox/dts/src/arm/am335x-myirtech-myd.dts:6.1-9 syntax error
> FATAL ERROR: Unable to parse input tree
> 
> Most likely this is the result of double inclusion of the file arm/am33xx.dtsi,
> first time from "am33xx.dtsi" and second from arm/am335x-myirtech-myd.dts.

Hi, you need to include if after the upstream DT. That's why it doesn't have
a /dts-v1/;

Cheers,
Ahmad

> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2022-05-25  8:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-24  7:30 Alexander Shiyan
2022-05-24  9:03 ` Marco Felsch
2022-05-24  9:21   ` Alexander Shiyan
2022-05-24 12:03     ` Marco Felsch
2022-05-24 12:28 ` Ahmad Fatoum
2022-05-25  6:23   ` Marco Felsch
2022-05-25  6:27   ` Alexander Shiyan
2022-05-25  8:16     ` Ahmad Fatoum [this message]
2022-05-25  8:33       ` Alexander Shiyan
2022-05-25  8:52         ` Ahmad Fatoum
2022-05-30  6:55 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1db17488-d759-712a-6014-8d2cde412474@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=eagle.alexander923@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox