mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: "U-Boot Version 2 (barebox)" <barebox@lists.infradead.org>
Subject: Re: [PATCH] Remove/adjust erroneous references to CONFIG_MODULE.
Date: Mon, 21 Dec 2009 14:22:16 +0100	[thread overview]
Message-ID: <20091221132216.GH15126@pengutronix.de> (raw)
In-Reply-To: <alpine.LFD.2.00.0912210703550.14660@localhost>

On Mon, Dec 21, 2009 at 07:07:04AM -0500, Robert P. J. Day wrote:
> 
> The correct config variable is CONFIG_MODULES, so tweak any references
> to the incorrect CONFIG_MODULE.
> 
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

Ok, applied

Sascha

> 
> ---
> 
>   can someone verify that this looks correct, as there are only three
> references to CONFIG_MODULE throughout the tree:
> 
>   * a superfluous one in common/Makefile that's already covered by
>     a test to CONFIG_MODULES
>   * a test in arch/ppc/Makefile
>   * a comment in include/module.h
> 
> so i want to make sure i tweaked all that appropriately.
> 
> 
> diff --git a/arch/ppc/Makefile b/arch/ppc/Makefile
> index 2c9c535..c24d3c3 100644
> --- a/arch/ppc/Makefile
> +++ b/arch/ppc/Makefile
> @@ -17,7 +17,7 @@ TEXT_BASE = $(CONFIG_TEXT_BASE)
>  CPPFLAGS += -DTEXT_BASE=$(TEXT_BASE) -P
> 
>  # Add cleanup flags
> -ifndef CONFIG_MODULE
> +ifndef CONFIG_MODULES
>  CPPFLAGS += -fdata-sections -ffunction-sections
>  endif
> 
> diff --git a/common/Makefile b/common/Makefile
> index d7a024b..0c075a9 100644
> --- a/common/Makefile
> +++ b/common/Makefile
> @@ -2,7 +2,6 @@ obj-$(CONFIG_SHELL_HUSH)	+= hush.o
>  obj-$(CONFIG_SHELL_SIMPLE)	+= parser.o
>  obj-$(CONFIG_GREGORIAN_CALENDER) += date.o
>  obj-$(CONFIG_OF_FLAT_TREE)	+= ft_build.o
> -obj-$(CONFIG_MODULE)		+= module.o
>  obj-$(CONFIG_KALLSYMS)		+= kallsyms.o
>  obj-$(CONFIG_ENV_HANDLING)	+= environment.o
>  obj-$(CONFIG_AUTO_COMPLETE)	+= complete.o
> diff --git a/include/module.h b/include/module.h
> index 03b226a..9d0e803 100644
> --- a/include/module.h
> +++ b/include/module.h
> @@ -71,7 +71,7 @@ int apply_relocate_add(Elf_Shdr *sechdrs,
>  		       struct module *mod);
>  #else
>  #define EXPORT_SYMBOL(sym)
> -#endif /* CONFIG_MODULE */
> +#endif /* CONFIG_MODULES */
> 
>  extern struct list_head module_list;
> 
> 
> ========================================================================
> Robert P. J. Day                               Waterloo, Ontario, CANADA
> 
>             Linux Consulting, Training and Kernel Pedantry.
> 
> Web page:                                          http://crashcourse.ca
> Twitter:                                       http://twitter.com/rpjday
> ========================================================================
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2009-12-21 13:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-21 12:07 Robert P. J. Day
2009-12-21 13:22 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091221132216.GH15126@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=rpjday@crashcourse.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox