[PATCH] ep93xx eth driver: Fix dump_xxx_queue() parameter list

[PATCH] ep93xx eth driver: Fix dump_xxx_queue() parameter list

[Matthias Kaehlcke]

ep93xx eth driver: Add missing parameter to dump_rx_status_queue(),
dump_tx_descriptor_queue() and dump_tx_status_queue()

Signed-off-by: Matthias Kaehlcke <matthias@kaehlcke.net>
---
 drivers/net/ep93xx.c |   32 ++++++++++++++++----------------
 1 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/drivers/net/ep93xx.c b/drivers/net/ep93xx.c
index aa1a005..392e5af 100644
--- a/drivers/net/ep93xx.c
+++ b/drivers/net/ep93xx.c
@@ -110,7 +110,7 @@ inline void dump_rx_descriptor_queue(struct eth_device *edev)
 /**
  * Dump all RX status queue entries to the terminal.
  */
-inline void dump_rx_status_queue(void)
+inline void dump_rx_status_queue(struct eth_device *edev)
 {
 	struct ep93xx_eth_priv *priv = ep93xx_get_priv(edev);
 	int i;
@@ -128,7 +128,7 @@ inline void dump_rx_status_queue(void)
 /**
  * Dump all TX descriptor queue entries to the terminal.
  */
-inline void dump_tx_descriptor_queue(void)
+inline void dump_tx_descriptor_queue(struct eth_device *edev)
 {
 	struct ep93xx_eth_priv *priv = ep93xx_get_priv(edev);
 	int i;
@@ -146,7 +146,7 @@ inline void dump_tx_descriptor_queue(void)
 /**
  * Dump all TX status queue entries to the terminal.
  */
-inline void dump_tx_status_queue(void)
+inline void dump_tx_status_queue(struct eth_device *edev)
 {
 	struct ep93xx_eth_priv *priv = ep93xx_get_priv(edev);
 	int i;
@@ -161,10 +161,10 @@ inline void dump_tx_status_queue(void)
 }
 #else
 #define dump_dev(x)
-#define dump_rx_descriptor_queue()
-#define dump_rx_status_queue()
-#define dump_tx_descriptor_queue()
-#define dump_tx_status_queue()
+#define dump_rx_descriptor_queue(x)
+#define dump_rx_status_queue(x)
+#define dump_tx_descriptor_queue(x)
+#define dump_tx_status_queue(x)
 #endif	/* defined(EP93XX_MAC_DEBUG) */
 
 /**
@@ -291,11 +291,11 @@ static int ep93xx_eth_open(struct eth_device *edev)
 	writel(TXCTL_STXON, &regs->txctl);
 
 	/* Dump data structures if we're debugging */
-	dump_dev();
-	dump_rx_descriptor_queue();
-	dump_rx_status_queue();
-	dump_tx_descriptor_queue();
-	dump_tx_status_queue();
+	dump_dev(edev);
+	dump_rx_descriptor_queue(edev);
+	dump_rx_status_queue(edev);
+	dump_tx_descriptor_queue(edev);
+	dump_tx_status_queue(edev);
 
 	pr_debug("-ep93xx_eth_open\n");
 
@@ -470,8 +470,8 @@ static int ep93xx_eth_rcv_packet(struct eth_device *edev)
 			pr_err("packet rx error, status %08X %08X\n",
 				priv->rx_sq.current->word1,
 				priv->rx_sq.current->word2);
-			dump_rx_descriptor_queue();
-			dump_rx_status_queue();
+			dump_rx_descriptor_queue(edev);
+			dump_rx_status_queue(edev);
 		}
 
 		/*
@@ -544,8 +544,8 @@ static int ep93xx_eth_send_packet(struct eth_device *edev,
 	if (!TX_STATUS_TXWE(priv->tx_sq.current)) {
 		pr_err("packet tx error, status %08X\n",
 			priv->tx_sq.current->word1);
-		dump_tx_descriptor_queue();
-		dump_tx_status_queue();
+		dump_tx_descriptor_queue(edev);
+		dump_tx_status_queue(edev);
 
 		/* TODO: Add better error handling? */
 		goto eth_send_failed_0;
-- 
1.6.5


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] ep93xx eth driver: Fix dump_xxx_queue() parameter list

[Sascha Hauer]

Hi Matthias,

On Mon, Feb 01, 2010 at 07:49:57PM +0100, Matthias Kaehlcke wrote:
> ep93xx eth driver: Add missing parameter to dump_rx_status_queue(),
> dump_tx_descriptor_queue() and dump_tx_status_queue()

Ok, applied.

Thanks
  Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox