From: Sascha Hauer <s.hauer@pengutronix.de>
To: Marc Reilly <marc@cpdesign.com.au>
Cc: barebox@lists.infradead.org
Subject: Re: mx35 3stack LCD power enable
Date: Mon, 12 Apr 2010 12:19:24 +0200 [thread overview]
Message-ID: <20100412101924.GU3688@pengutronix.de> (raw)
In-Reply-To: <201004121422.45667.marc@cpdesign.com.au>
Hi Marc,
On Mon, Apr 12, 2010 at 02:22:45PM +1000, Marc Reilly wrote:
> Hi,
>
> These patches enable power to the mx35 3stack LCD.
Thanks for working on this. All applied.
>
> (First time -so please pardon any transgressions of patching etiquette.)
As you are using git please consider sending patches with git
send-email next time. It sends patches inline and one mail per patch.
This helps a lot in reviewing and applying the patches.
>
> It'd be nice for someone to double check what I've done in
> f3s_pmic_init_all(). I'm not sure what the original author was intending to
> turn on/off and whether these patches break that. I've preserved the bit
> banging of the physical lines themselves under the assumption that whatever it
> was doing before was the correct/intended behavior.
Looks good, though I haven't tested it yet.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2010-04-12 10:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-12 4:22 Marc Reilly
2010-04-12 10:19 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100412101924.GU3688@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=marc@cpdesign.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox