mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Eric Bénard" <eric@eukrea.com>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [PATCH 2/3] Add support for Eukrea's CPUIMX25
Date: Mon, 17 May 2010 11:58:54 +0200	[thread overview]
Message-ID: <20100517095854.GY31199@pengutronix.de> (raw)
In-Reply-To: <4BF11043.8050400@eukrea.com>

On Mon, May 17, 2010 at 11:45:39AM +0200, Eric Bénard wrote:
> Hi Sascha,
>
> v2 of the patch passed through checkpatch so no trailing whitespaces  
> should left.
>
> Le 17/05/2010 11:14, Sascha Hauer a écrit :
>> Care to rewrite this in C like some other boards already do?
>> I will commit it as is though, no showstopper.
>>
> I put this on the todo list, exercise seems interesting so I'll do it  
> asap ;-)

Ok, the patch looks ok apart from the comment I made. I'll wait applying
it for some time. Just ping me before the next release if you want me to
apply the assembler version.


Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2010-05-17  9:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-13 12:36 [PATCH 1/3] i.MX25 : add Framebuffer support Eric Benard
2010-05-13 12:36 ` [PATCH 2/3] Add support for Eukrea's CPUIMX25 Eric Benard
2010-05-13 12:36   ` [PATCH 3/3] freescale-mx*5-3-stack : fix __flash_header_start Eric Benard
2010-05-17  9:17     ` Sascha Hauer
2010-05-17  9:14   ` [PATCH 2/3] Add support for Eukrea's CPUIMX25 Sascha Hauer
2010-05-17  9:43     ` [PATCH v2] " Eric Bénard
2010-05-17  9:57       ` Sascha Hauer
2010-05-17  9:45     ` [PATCH 2/3] " Eric Bénard
2010-05-17  9:58       ` Sascha Hauer [this message]
2010-05-17  9:16 ` [PATCH 1/3] i.MX25 : add Framebuffer support Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100517095854.GY31199@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=eric@eukrea.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox