From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Eric Bénard" <eric@eukrea.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/3] unbreak imx-ipu-fb
Date: Thu, 24 Jun 2010 12:34:55 +0200 [thread overview]
Message-ID: <20100624103455.GT12115@pengutronix.de> (raw)
In-Reply-To: <1277372997-6472-2-git-send-email-eric@eukrea.com>
On Thu, Jun 24, 2010 at 11:49:56AM +0200, Eric Bénard wrote:
> commit c3789cd49b43ec1c414ba1b0e9f48e8ccc19f8e1 set fb0.enable to 0
> as a default. Re-enabling the display doesn't work after this.
> Removing sdc_enable_channel from imxfb_probe fix this problem.
>
> This patch also remove verbose log from ipu_fb_disable.
I already stumbled upon this. I prefer the following patch which fixes
the enabling/disabling of the framebuffer.
Sascha
imx ipu fb: remove checking of IPU_CHA_BUF0_RDY
This check prevents the driver from successfully enabling/disabling
the controller more than once, because the second time we get
here the check fails and the drivers bails out. We do not need this
check at all, so remove it.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
diff --git a/drivers/video/imx-ipu-fb.c b/drivers/video/imx-ipu-fb.c
index 0bd86b2..d9b94e4 100644
--- a/drivers/video/imx-ipu-fb.c
+++ b/drivers/video/imx-ipu-fb.c
@@ -664,12 +664,6 @@ static int ipu_enable_channel(struct ipu_fb_info *fbi, enum ipu_channel channel)
static int ipu_update_channel_buffer(struct ipu_fb_info *fbi,
enum ipu_channel channel, void *buf)
{
- u32 reg;
-
- reg = reg_read(fbi, IPU_CHA_BUF0_RDY);
- if (reg & (1UL << channel))
- return -EACCES;
-
/* 44.3.3.1.9 - Row Number 1 (WORD1, offset 0) */
reg_write(fbi, dma_param_addr(channel) + 0x0008UL, IPU_IMA_ADDR);
reg_write(fbi, (u32)buf, IPU_IMA_DATA);
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2010-06-24 10:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 9:49 [PATCH 1/3] fix command loadb Eric Bénard
2010-06-24 9:49 ` [PATCH 2/3] unbreak imx-ipu-fb Eric Bénard
2010-06-24 9:49 ` [PATCH 3/3] eukrea_cpuimx35: better handling of backlight Eric Bénard
2010-06-24 10:48 ` Sascha Hauer
2010-06-24 11:48 ` Eric Bénard
2010-06-24 10:34 ` Sascha Hauer [this message]
2010-06-24 9:53 ` [PATCH 1/3] fix command loadb Eric Bénard
2010-06-24 10:38 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100624103455.GT12115@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=eric@eukrea.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox