Barebox 'git describe' strangeness

Barebox 'git describe' strangeness

[Baruch Siach]

Hi barebox list,

For some reason 'git describe' shows me:

v2009.12.0-178-gdc882c3

I.e. git doesn't find the more recent v2010.06.0 tag. What is worse is that 
the top-level Makefile takes the '-178-gdc882c3' part and attaches it to 
'2010.06.0', making the output of the 'version' command:

barebox 2010.06.0-00178-gcc827a1 (Jul  1 2010 - 09:02:45)

which is plain wrong.

Can anyone here explain what's going on?

BTW, I'm using git version 1.7.1 from Debian testing.

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: Barebox 'git describe' strangeness

[Eric Bénard]

Hi Baruch,

Le 01/07/2010 09:13, Baruch Siach a écrit :
> Hi barebox list,
>
> For some reason 'git describe' shows me:
>
> v2009.12.0-178-gdc882c3
>
> I.e. git doesn't find the more recent v2010.06.0 tag. What is worse is that
> the top-level Makefile takes the '-178-gdc882c3' part and attaches it to
> '2010.06.0', making the output of the 'version' command:
>
> barebox 2010.06.0-00178-gcc827a1 (Jul  1 2010 - 09:02:45)
>
> which is plain wrong.
>
> Can anyone here explain what's going on?
>
same thing here (the man says "By default (without --all or --tags) git 
describe only shows annotated tags." so maybe the tags after 2009.12.0 
are not annotated ?)

git describe --tags
returns : v2010.06.0-29-g9ad1fe6

Eric

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: Barebox 'git describe' strangeness

[Sascha Hauer]

On Thu, Jul 01, 2010 at 09:28:22AM +0200, Eric Bénard wrote:
> Hi Baruch,
>
> Le 01/07/2010 09:13, Baruch Siach a écrit :
>> Hi barebox list,
>>
>> For some reason 'git describe' shows me:
>>
>> v2009.12.0-178-gdc882c3
>>
>> I.e. git doesn't find the more recent v2010.06.0 tag. What is worse is that
>> the top-level Makefile takes the '-178-gdc882c3' part and attaches it to
>> '2010.06.0', making the output of the 'version' command:
>>
>> barebox 2010.06.0-00178-gcc827a1 (Jul  1 2010 - 09:02:45)
>>
>> which is plain wrong.
>>
>> Can anyone here explain what's going on?
>>
> same thing here (the man says "By default (without --all or --tags) git  
> describe only shows annotated tags." so maybe the tags after 2009.12.0  
> are not annotated ?)

No, they are not. Sorry, I'm still learning git...

I will fix this from the next release on.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: Barebox 'git describe' strangeness

[Eric Bénard]

Le 01/07/2010 09:47, Sascha Hauer a écrit :
> On Thu, Jul 01, 2010 at 09:28:22AM +0200, Eric Bénard wrote:
>> same thing here (the man says "By default (without --all or --tags) git
>> describe only shows annotated tags." so maybe the tags after 2009.12.0
>> are not annotated ?)
>
> No, they are not. Sorry, I'm still learning git...
>
so we are all learning git ;-)

Thanks,
Eric

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: Barebox 'git describe' strangeness

[Baruch Siach]

Hi Sascha,

On Thu, Jul 01, 2010 at 09:47:39AM +0200, Sascha Hauer wrote:
> On Thu, Jul 01, 2010 at 09:28:22AM +0200, Eric Bénard wrote:
> > Le 01/07/2010 09:13, Baruch Siach a écrit :
> >> Hi barebox list,
> >>
> >> For some reason 'git describe' shows me:
> >>
> >> v2009.12.0-178-gdc882c3
> >>
> >> I.e. git doesn't find the more recent v2010.06.0 tag. What is worse is that
> >> the top-level Makefile takes the '-178-gdc882c3' part and attaches it to
> >> '2010.06.0', making the output of the 'version' command:
> >>
> >> barebox 2010.06.0-00178-gcc827a1 (Jul  1 2010 - 09:02:45)
> >>
> >> which is plain wrong.
> >>
> >> Can anyone here explain what's going on?
> >>
> > same thing here (the man says "By default (without --all or --tags) git  
> > describe only shows annotated tags." so maybe the tags after 2009.12.0  
> > are not annotated ?)
> 
> No, they are not. Sorry, I'm still learning git...
> 
> I will fix this from the next release on.

I've posted a patch adding --tags to 'git describe'. This should fix the 
problem for older tags.

Thanks Eric.

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox