[PATCH] init.h: introduce fake define (__init & __initdata) to simplify the linux sync

[PATCH] init.h: introduce fake define (__init & __initdata) to simplify the linux sync

[Jean-Christophe PLAGNIOL-VILLARD]

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
---
 include/init.h |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/include/init.h b/include/init.h
index c5dea07..accc4d0 100644
--- a/include/init.h
+++ b/include/init.h
@@ -1,6 +1,12 @@
 #ifndef _INIT_H
 #define _INIT_H
 
+/*
+ * fake define to simplify the linux sync
+ */
+#define __init
+#define __initdata
+
 typedef int (*initcall_t)(void);
 
 #define __define_initcall(level,fn,id) \
-- 
1.7.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] init.h: introduce fake define (__init & __initdata) to simplify the linux sync

[Baruch Siach]

Hi Jean-Christophe,

On Wed, Aug 04, 2010 at 04:20:14AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  include/init.h |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/include/init.h b/include/init.h
> index c5dea07..accc4d0 100644
> --- a/include/init.h
> +++ b/include/init.h
> @@ -1,6 +1,12 @@
>  #ifndef _INIT_H
>  #define _INIT_H
>  
> +/*
> + * fake define to simplify the linux sync
> + */
> +#define __init
> +#define __initdata
> +

IMO, having useless __init/__initdata in the code adds noise, and reduces 
readability.  These can be easily removed as code gets moved from Linux to 
Barebox.

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] init.h: introduce fake define (__init & __initdata) to simplify the linux sync

[Jean-Christophe PLAGNIOL-VILLARD]

> >  
> > +/*
> > + * fake define to simplify the linux sync
> > + */
> > +#define __init
> > +#define __initdata
> > +
> 
> IMO, having useless __init/__initdata in the code adds noise, and reduces 
> readability.  These can be easily removed as code gets moved from Linux to 
> Barebox.

but make impossible to apply patch directly or very quickly update the code
so this will make the job of maintainance easier

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox