From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.72 #1 (Red Hat Linux)) id 1OrDzg-0004Er-QM for barebox@lists.infradead.org; Thu, 02 Sep 2010 17:54:41 +0000 Date: Thu, 2 Sep 2010 19:54:32 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Message-ID: <20100902175432.GT14214@pengutronix.de> References: <20100902141001.GA28968@game.jcrosoft.org> <1283436624-29567-5-git-send-email-plagnioj@jcrosoft.com> <20100902152933.GQ14214@pengutronix.de> <20100902153220.GR14214@pengutronix.de> <20100902155421.GB28968@game.jcrosoft.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20100902155421.GB28968@game.jcrosoft.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 5/9] vsprintf: add %w and %w support to print unit To: Jean-Christophe PLAGNIOL-VILLARD Cc: barebox@lists.infradead.org On Thu, Sep 02, 2010 at 05:54:21PM +0200, Jean-Christophe PLAGNIOL-VILLARD = wrote: > On 17:32 Thu 02 Sep , Uwe Kleine-K=F6nig wrote: > > Hello, > > = > > On Thu, Sep 02, 2010 at 05:29:33PM +0200, Uwe Kleine-K=F6nig wrote: > > > Hello Jean-Christophe, > > > = > > > On Thu, Sep 02, 2010 at 04:10:20PM +0200, Jean-Christophe PLAGNIOL-VI= LLARD wrote: > > > > Show a '%w' or %W thing. > > > > This will show a frequency or byte at format xxx[.xxx] [ kMG] > > > > the precision can not excess the base kMG of the current unit > > > > otherwise it will be automatically reduce > > > > if no precision is specified and there is rest we will use a default > > > > precision of 3 as 66.667 M > > > > base will be typically 1000 for Hz or B and 1024 for iB > > > I see this used e.g. as: > > > = > > > printk("%WiB", somevalue) > > > = > > > right? hmm, what if somevalue is say 5? If I understand correctly t= he > > > output then is: "5 iB". > > [I forgot to complete this, sorry] > > = > > "5 iB" looks ugly, doesn't it? Do you care enough to fix that? > After it's everyone preference > = > What do you think of > 100MHz > 100 MHz > = > 1 Hz > 1Hz > = > 100 MiB > 100MiB > = > 1iB > 1 iB > = > so which one? IMHO iB doesn't make sense. What should be the difference to a plain B? And if "%WiB" yields 100MiB for 100*1024**2, it should yield 5B for 5 but neither "5 iB" nor "5iB" nor "5 B". Best regards Uwe -- = Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox