From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: "Eric Bénard" <eric@eukrea.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] unbreak bootm
Date: Wed, 13 Oct 2010 12:08:59 +0200 [thread overview]
Message-ID: <20101013100859.GN7412@game.jcrosoft.org> (raw)
In-Reply-To: <1286963684-16359-1-git-send-email-eric@eukrea.com>
On 11:54 Wed 13 Oct , Eric Bénard wrote:
> commit a3c1e5d888d0ee317ffc7635694684bb71213c9c was
> not tested as all the tests are wrong and it breaks bootm
I test it but no see it
>
> Signed-off-by: Eric Bénard <eric@eukrea.com>
> ---
> commands/bootm.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/commands/bootm.c b/commands/bootm.c
> index 83d36d3..666deeb 100644
> --- a/commands/bootm.c
> +++ b/commands/bootm.c
> @@ -167,7 +167,7 @@ struct image_handle *map_image(const char *filename, int verify)
> goto err_out;
> }
>
> - if (image_check_magic(header)) {
> + if (! image_check_magic(header)) {
no space after !
> puts ("Bad Magic Number\n");
> goto err_out;
> }
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2010-10-13 10:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 9:54 Eric Bénard
2010-10-13 10:08 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2010-10-13 10:19 ` Eric Bénard
2010-10-13 11:14 ` Sascha Hauer
2010-10-13 12:28 ` Eric Bénard
2010-10-13 13:08 ` Jean-Christophe PLAGNIOL-VILLARD
2010-10-13 15:40 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101013100859.GN7412@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=eric@eukrea.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox