From: Juergen Beisert <jbe@pengutronix.de>
To: barebox@lists.infradead.org
Subject: Re: [RFC] S3C24xx: Enable only the clocks of used units
Date: Tue, 19 Oct 2010 08:55:18 +0200 [thread overview]
Message-ID: <201010190855.18736.jbe@pengutronix.de> (raw)
In-Reply-To: <20101019014246.GK11127@game.jcrosoft.org>
Jean-Christophe PLAGNIOL-VILLARD wrote:
> > - mov r1, #0xFFFFFFF0
> > + /*
> > + * Disable the clocks for most devices on this chip.
> > + * They will be enabled again on demand
> > + */
> > +#ifdef CONFIG_S3C24XX_NAND_BOOT
> > + ldr r1, =0x6010 /* (CLK_RTC | CLK_GPIO | CLK_NAND) */
> > +#else
> > + mov r1, #0x6000 /* (CLK_RTC | CLK_GPIO) */
>
> how about use the macro and define a macro to avoid the ifdef
I tried with macros, but the assembler failed. Can't remember why. But I tried
again a few minutes ago .... and now it works (????).
Do you mean something like this instead?
[...]
#ifdef CONFIG_S3C24XX_NAND_BOOT
# define FORCED_CLOCKS (CLK_RTC | CLK_GPIO | CLK_NAND)
#else
# define FORCED_CLOCKS (CLK_RTC | CLK_GPIO)
#endif
/*
* Disable the clocks for most devices on this chip.
* They will be enabled again on demand
*/
ldr r1, =FORCED_CLOCKS
[...]
jbe
--
Pengutronix e.K. | Juergen Beisert |
Linux Solutions for Science and Industry | Phone: +49-8766-939 228 |
Vertretung Sued/Muenchen, Germany | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2010-10-19 6:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-18 16:59 Juergen Beisert
2010-10-19 1:42 ` Jean-Christophe PLAGNIOL-VILLARD
2010-10-19 6:55 ` Juergen Beisert [this message]
2010-10-19 8:27 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201010190855.18736.jbe@pengutronix.de \
--to=jbe@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox