From: Sascha Hauer <s.hauer@pengutronix.de>
To: Marek Belisko <marek.belisko@open-nandra.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/5] fs: Fix sparse warning.
Date: Fri, 19 Nov 2010 09:36:21 +0100 [thread overview]
Message-ID: <20101119083621.GC6017@pengutronix.de> (raw)
In-Reply-To: <1290086971-5467-3-git-send-email-marek.belisko@open-nandra.com>
On Thu, Nov 18, 2010 at 02:29:28PM +0100, Marek Belisko wrote:
> Patch fix following sparse warning:
> fs/fs.c:757:28: warning: dubious: !x & y
Don't be shy. You actually found a real bug. I changed the commit log a
bit to reflect that. I added this one to master and the others to next.
Sascha
>
> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
> ---
> fs/fs.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/fs.c b/fs/fs.c
> index 3b5f284..7d8dea7 100644
> --- a/fs/fs.c
> +++ b/fs/fs.c
> @@ -754,7 +754,7 @@ int mount(const char *device, const char *fsname, const char *_path)
> }
>
> fsdev = xzalloc(sizeof(struct fs_device_d));
> - if (!fs_drv->flags & FS_DRIVER_NO_DEV) {
> + if (!(fs_drv->flags & FS_DRIVER_NO_DEV)) {
> fsdev->backingstore = strdup(device);
> if (!device) {
> printf("need a device for driver %s\n", fsname);
> --
> 1.7.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2010-11-19 8:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 13:29 [PATCH 0/5] Various sparse fixes Marek Belisko
2010-11-18 13:29 ` [PATCH 1/5] common: Add define for IOMEM helper macro Marek Belisko
2010-11-18 13:29 ` [PATCH 2/5] fs: Fix sparse warning Marek Belisko
2010-11-19 8:36 ` Sascha Hauer [this message]
2010-11-18 13:29 ` [PATCH 3/5] mtd: " Marek Belisko
2010-11-18 13:29 ` [PATCH 4/5] nand_s3c2410: Fix sparse warnings Marek Belisko
2010-11-18 13:29 ` [PATCH 5/5] smc91111: Various sparse fixes Marek Belisko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101119083621.GC6017@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=marek.belisko@open-nandra.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox