* [PATCH] STM/MCI: Fix wrong register bit
@ 2010-12-03 13:59 Juergen Beisert
2010-12-05 10:50 ` Uwe Kleine-König
0 siblings, 1 reply; 2+ messages in thread
From: Juergen Beisert @ 2010-12-03 13:59 UTC (permalink / raw)
To: barebox
Signed-off-by: Juergen Beisert <jbe@pengutronix.de>
---
drivers/mci/stm378x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: barebox-git/drivers/mci/stm378x.c
===================================================================
--- barebox-git.orig/drivers/mci/stm378x.c
+++ barebox-git/drivers/mci/stm378x.c
@@ -52,7 +52,7 @@
# define SSP_CTRL0_SFTRST (1 << 31)
# define SSP_CTRL0_CLKGATE (1 << 30)
# define SSP_CTRL0_RUN (1 << 29)
-# define SSP_CTRL0_LOCK_CS (1 << 29)
+# define SSP_CTRL0_LOCK_CS (1 << 27)
# define SSP_CTRL0_READ (1 << 25)
# define SSP_CTRL0_IGNORE_CRC (1 << 26)
# define SSP_CTRL0_DATA_XFER (1 << 24)
--
Pengutronix e.K. | Juergen Beisert |
Linux Solutions for Science and Industry | Phone: +49-8766-939 228 |
Vertretung Sued/Muenchen, Germany | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] STM/MCI: Fix wrong register bit
2010-12-03 13:59 [PATCH] STM/MCI: Fix wrong register bit Juergen Beisert
@ 2010-12-05 10:50 ` Uwe Kleine-König
0 siblings, 0 replies; 2+ messages in thread
From: Uwe Kleine-König @ 2010-12-05 10:50 UTC (permalink / raw)
To: Juergen Beisert; +Cc: barebox
On Fri, Dec 03, 2010 at 02:59:50PM +0100, Juergen Beisert wrote:
>
Maybe add something like: "The define isn't used up to now, so the wrong
offset didn't stick out before. For the same reason this fix isn't
critical." to the changelog?
Uwe
> Signed-off-by: Juergen Beisert <jbe@pengutronix.de>
> ---
> drivers/mci/stm378x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: barebox-git/drivers/mci/stm378x.c
> ===================================================================
> --- barebox-git.orig/drivers/mci/stm378x.c
> +++ barebox-git/drivers/mci/stm378x.c
> @@ -52,7 +52,7 @@
> # define SSP_CTRL0_SFTRST (1 << 31)
> # define SSP_CTRL0_CLKGATE (1 << 30)
> # define SSP_CTRL0_RUN (1 << 29)
> -# define SSP_CTRL0_LOCK_CS (1 << 29)
> +# define SSP_CTRL0_LOCK_CS (1 << 27)
> # define SSP_CTRL0_READ (1 << 25)
> # define SSP_CTRL0_IGNORE_CRC (1 << 26)
> # define SSP_CTRL0_DATA_XFER (1 << 24)
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-05 10:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-03 13:59 [PATCH] STM/MCI: Fix wrong register bit Juergen Beisert
2010-12-05 10:50 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox