From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail7.tpgi.com.au ([203.12.160.103]) by canuck.infradead.org with esmtps (Exim 4.72 #1 (Red Hat Linux)) id 1PUQr0-000320-6J for barebox@lists.infradead.org; Sun, 19 Dec 2010 21:31:43 +0000 From: Marc Reilly Date: Mon, 20 Dec 2010 08:31:34 +1100 References: <1292685309-32326-1-git-send-email-s.hauer@pengutronix.de> <1292685309-32326-3-git-send-email-s.hauer@pengutronix.de> In-Reply-To: <1292685309-32326-3-git-send-email-s.hauer@pengutronix.de> MIME-Version: 1.0 Message-Id: <201012200831.34131.marc@cpdesign.com.au> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 2/7] basic LED support To: Sascha Hauer Cc: barebox@lists.infradead.org Hi Sascha, Thanks, this works well for my board. (tri colour led). Was drivers/led/led-triggers.c missing from the patch set? I haven't been able to compile with trigger support... > +/** > + * led_register - Register a LED > + * @param led the led > + */ > +int led_register(struct led *led) > +{ > + led->num = num_leds++; > + > + list_add_tail(&led->list, &leds); > + > + return 0; > +} How about being able to register a led at a specific number? This means that boot/init scripts that want to interact with leds don't rely on the order that they are registered. I also like the suggestion of associating a name to LEDs. This may even be a better fit for scripting than reserved numbering. > + > +/** > + * led_unregister - Unegister a LED > + * @param led the led > + */ > +void led_unregister(struct led *led) > +{ > + list_del(&led->list); > +} > diff --git a/include/led.h b/include/led.h > new file mode 100644 > index 0000000..62d0d08 > --- /dev/null > +++ b/include/led.h > @@ -0,0 +1,25 @@ > +#ifndef __LED_H > +#define __LED_H > + > +struct led { > + unsigned long triger; Spelling typo? (Should this be trigger ?) > + void (*set)(struct led *, unsigned int value); > + int max_value; > + int num; > + struct list_head list; > +}; > + > +struct led *led_by_number(int no); > + Cheers Marc _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox