From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Franck JULLIEN <franck.jullien@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] Add a board specific fancy banner
Date: Sun, 26 Dec 2010 12:48:41 +0100 [thread overview]
Message-ID: <20101226114841.GH14221@pengutronix.de> (raw)
In-Reply-To: <AANLkTik+7KJrf3H6ZW3i9pA115p2Gn=k=CXYHg5YJwRY@mail.gmail.com>
Hello Franck,
On Thu, Dec 23, 2010 at 10:42:34PM +0100, Franck JULLIEN wrote:
> This is the first time I'm using git and submit a patch so if I made a
> mistake be cool :)
:-)
> common/Kconfig | 6 ++++++
> common/console.c | 10 ++++++++++
> 2 files changed, 16 insertions(+), 0 deletions(-)
>
> diff --git a/common/Kconfig b/common/Kconfig
> index 617f640..d46c8fc 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -248,6 +248,12 @@ config HUSH_FANCY_PROMPT
> Allow to set PS1 from the command line. PS1 can have several escaped
> commands
> like \h for CONFIG_BOARDINFO or \w for the current working directory.
>
> +config BOARD_BANNER
> + bool
> + prompt "allow a board specific fancy banner"
> + help
> + Allow to define a custom board banner (you must define BOARD_BANNER in
> your config.h)
Your patch is line broken, which makes is unapplicable. I don't know
which MUA you're using, but you either should use git send-email or take
a look into
http://git.kernel.org/?p=git/git.git;a=blob;f=Documentation/SubmittingPatches;h=72741ebda12de8fbf786f12531d70ab465eecf42;hb=HEAD#l333
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2010-12-26 11:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-23 21:42 Franck JULLIEN
2010-12-25 6:38 ` Jean-Christophe PLAGNIOL-VILLARD
2010-12-26 11:48 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101226114841.GH14221@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=franck.jullien@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox