From: Sascha Hauer <s.hauer@pengutronix.de>
To: Franck JULLIEN <franck.jullien@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] Add an option to set a board specific banner
Date: Mon, 3 Jan 2011 12:41:44 +0100 [thread overview]
Message-ID: <20110103114144.GL6017@pengutronix.de> (raw)
In-Reply-To: <1293713374-3476-1-git-send-email-franck.jullien@gmail.com>
Hi Franck,
On Thu, Dec 30, 2010 at 01:49:34PM +0100, Franck JULLIEN wrote:
> Allow a board specific fancy banner
>
> ---
>
> I removed the default fancy banner and do it like Jean-Christophe suggested it.
>
> common/Kconfig | 6 ++++++
> common/console.c | 7 ++++++-
> 2 files changed, 12 insertions(+), 1 deletions(-)
>
> diff --git a/common/Kconfig b/common/Kconfig
> index 617f640..d32c1ce 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -248,6 +248,12 @@ config HUSH_FANCY_PROMPT
> Allow to set PS1 from the command line. PS1 can have several escaped commands
> like \h for CONFIG_BOARDINFO or \w for the current working directory.
>
> +config BOARD_BANNER
> + bool
> + prompt "allow a board specific fancy banner"
> + help
> + Allow to define a custom board banner (you can define CONFIG_BOARD_BANNER_TEXT in your config.h)
> +
> config HUSH_GETOPT
> bool
> depends on SHELL_HUSH
> diff --git a/common/console.c b/common/console.c
> index 82786f2..7caef11 100644
> --- a/common/console.c
> +++ b/common/console.c
> @@ -46,7 +46,12 @@ EXPORT_SYMBOL(console_list);
> static void display_banner (void)
> {
> printf (RELOC("\n\n%s\n\n"), RELOC_VAR(version_string));
> - printf(RELOC("Board: " CONFIG_BOARDINFO "\n"));
> +
> +#ifndef CONFIG_BOARD_BANNER
> +#undef CONFIG_BOARD_BANNER_TEXT
> +#define CONFIG_BOARD_BANNER_TEXT "Board: " CONFIG_BOARDINFO "\n"
> +#endif
> + printf(RELOC(CONFIG_BOARD_BANNER_TEXT));
> }
I do not really understand this patch. CONFIG_BOARDINFO is board
specific already, why would we want to add another option?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-01-03 11:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20101230034811.GS19266@game.jcrosoft.org>
2010-12-30 12:49 ` Franck JULLIEN
2010-12-31 7:24 ` Jean-Christophe PLAGNIOL-VILLARD
2011-01-03 11:41 ` Sascha Hauer [this message]
2011-01-03 12:45 ` Franck JULLIEN
2011-01-03 13:50 ` Sascha Hauer
2011-01-03 19:42 ` Franck JULLIEN
2011-01-03 23:53 ` Peter Korsgaard
2011-01-04 9:00 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110103114144.GL6017@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=franck.jullien@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox